You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@oozie.apache.org by Azrael Park <az...@nexr.com> on 2014/07/27 09:09:09 UTC

Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23968/
-----------------------------------------------------------

Review request for oozie.


Bugs: OOZIE-1939
    https://issues.apache.org/jira/browse/OOZIE-1939


Repository: oozie-git


Description
-------

Because of ThreadLocal, I added setLogInfo() at XCommand.
If the logInfo in setLogInfo() is enough, It might not need to set logInfo in loadState().


Diffs
-----

  core/src/main/java/org/apache/oozie/command/XCommand.java 44e1133 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 9ac66b2 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 0a9e4fa 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java 562b211 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java ffe85f0 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java c774f8e 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1ca055d 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 5a5bf98 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 6e3af70 
  core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java a2748c4 
  core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java ae71924 
  core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 39c522d 
  core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 42cb290 
  core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 863bf7d 
  core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java f3a4ba9 
  core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 0c4c548 
  core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 41e6732 
  core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 64d4822 
  core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 37a2f8b 
  core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 5dd06ca 
  core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 7b8ee3b 
  core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 4a7283f 
  core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 635186a 
  core/src/main/java/org/apache/oozie/util/LogUtils.java 814caff 

Diff: https://reviews.apache.org/r/23968/diff/


Testing
-------

Done manual test.


Thanks,

Azrael Park

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

Posted by Azrael Park <az...@nexr.com>.


> On Aug. 5, 2014, 12:30 p.m., shwethags wrote:
> > We also need LogInfo.clearPrefix() in one of the filters for tomcat threadpool

Added in HostnameFilter.


- Azrael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23968/#review49595
-----------------------------------------------------------


On Aug. 6, 2014, 6:40 a.m., Azrael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23968/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2014, 6:40 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1939
>     https://issues.apache.org/jira/browse/OOZIE-1939
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Because of ThreadLocal, I added setLogInfo() at XCommand.
> If the logInfo in setLogInfo() is enough, It might not need to set logInfo in loadState().
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf 
>   core/src/main/java/org/apache/oozie/command/XCommand.java 44e1133 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 41ad8ae 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 8ccab0e 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 65eb272 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java c101f45 
>   core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java 0a04a02 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java f5f4b3f 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 74fbcab 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java 5d6ef65 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 9ac66b2 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 0a9e4fa 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java 562b211 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java ffe85f0 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java c774f8e 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1ca055d 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 5a5bf98 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 6e3af70 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java ed85a40 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java d2b4659 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java a2748c4 
>   core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 91e9e09 
>   core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java cc2127a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java ae71924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 735b295 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 0aae1e6 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java b1b2fcd 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java a177101 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java d6e47da 
>   core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 39c522d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 42cb290 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 863bf7d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java f3a4ba9 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 0c4c548 
>   core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 41e6732 
>   core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 64d4822 
>   core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 37a2f8b 
>   core/src/main/java/org/apache/oozie/command/wf/NotificationXCommand.java 651b5fd 
>   core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 5dd06ca 
>   core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 7b8ee3b 
>   core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 4a7283f 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java 5e9abcf 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 66baca1 
>   core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 635186a 
>   core/src/main/java/org/apache/oozie/service/CallableQueueService.java 093eb08 
>   core/src/main/java/org/apache/oozie/service/EventHandlerService.java 761537b 
>   core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java 541faca 
>   core/src/main/java/org/apache/oozie/servlet/HostnameFilter.java afba9ec 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java f7458dc 
>   core/src/main/java/org/apache/oozie/util/LogUtils.java 814caff 
>   core/src/test/java/org/apache/oozie/util/TestXLog.java 824e5dc 
> 
> Diff: https://reviews.apache.org/r/23968/diff/
> 
> 
> Testing
> -------
> 
> Done manual test.
> 
> 
> Thanks,
> 
> Azrael Park
> 
>

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

Posted by sh...@inmobi.com.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23968/#review49595
-----------------------------------------------------------


We also need LogInfo.clearPrefix() in one of the filters for tomcat threadpool

- shwethags


On Aug. 5, 2014, 7:49 a.m., Azrael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23968/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 7:49 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1939
>     https://issues.apache.org/jira/browse/OOZIE-1939
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Because of ThreadLocal, I added setLogInfo() at XCommand.
> If the logInfo in setLogInfo() is enough, It might not need to set logInfo in loadState().
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf 
>   core/src/main/java/org/apache/oozie/command/XCommand.java 44e1133 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 41ad8ae 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 8ccab0e 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 65eb272 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java c101f45 
>   core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java 0a04a02 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java f5f4b3f 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 74fbcab 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java 5d6ef65 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 9ac66b2 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 0a9e4fa 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java 562b211 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java ffe85f0 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java c774f8e 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1ca055d 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 5a5bf98 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 6e3af70 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java ed85a40 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java d2b4659 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java a2748c4 
>   core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 91e9e09 
>   core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java cc2127a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java ae71924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 735b295 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 0aae1e6 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java b1b2fcd 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java a177101 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java d6e47da 
>   core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 39c522d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 42cb290 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 863bf7d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java f3a4ba9 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 0c4c548 
>   core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 41e6732 
>   core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 64d4822 
>   core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 37a2f8b 
>   core/src/main/java/org/apache/oozie/command/wf/NotificationXCommand.java 651b5fd 
>   core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 5dd06ca 
>   core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 7b8ee3b 
>   core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 4a7283f 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java 5e9abcf 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 66baca1 
>   core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 635186a 
>   core/src/main/java/org/apache/oozie/service/CallableQueueService.java 093eb08 
>   core/src/main/java/org/apache/oozie/service/EventHandlerService.java 761537b 
>   core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java 541faca 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java f7458dc 
>   core/src/main/java/org/apache/oozie/util/LogUtils.java 814caff 
>   core/src/main/java/org/apache/oozie/util/XLog.java 31a5ba0 
>   core/src/test/java/org/apache/oozie/util/TestXLog.java 824e5dc 
> 
> Diff: https://reviews.apache.org/r/23968/diff/
> 
> 
> Testing
> -------
> 
> Done manual test.
> 
> 
> Thanks,
> 
> Azrael Park
> 
>

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

Posted by sh...@inmobi.com.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23968/#review49586
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/service/CallableQueueService.java
<https://reviews.apache.org/r/23968/#comment86820>

    We don't need to call callable.setLogInfo() as the data wouldn't be loaded at this point. Just XLog.Info.get().clear() will be enough



core/src/main/java/org/apache/oozie/service/CallableQueueService.java
<https://reviews.apache.org/r/23968/#comment86821>

    Don't need afterExecute()



core/src/main/java/org/apache/oozie/util/XLog.java
<https://reviews.apache.org/r/23968/#comment86826>

    Instead of calling createPrefix() for every log(), we can call createPrefix() in LogUtils.setLogInfo() which stores prefix. log() can just get this prefix


- shwethags


On Aug. 5, 2014, 7:49 a.m., Azrael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23968/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 7:49 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1939
>     https://issues.apache.org/jira/browse/OOZIE-1939
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Because of ThreadLocal, I added setLogInfo() at XCommand.
> If the logInfo in setLogInfo() is enough, It might not need to set logInfo in loadState().
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf 
>   core/src/main/java/org/apache/oozie/command/XCommand.java 44e1133 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 41ad8ae 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 8ccab0e 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 65eb272 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java c101f45 
>   core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java 0a04a02 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java f5f4b3f 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 74fbcab 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java 5d6ef65 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 9ac66b2 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 0a9e4fa 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java 562b211 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java ffe85f0 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java c774f8e 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1ca055d 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 5a5bf98 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 6e3af70 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java ed85a40 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java d2b4659 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java a2748c4 
>   core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 91e9e09 
>   core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java cc2127a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java ae71924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 735b295 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 0aae1e6 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java b1b2fcd 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java a177101 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java d6e47da 
>   core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 39c522d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 42cb290 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 863bf7d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java f3a4ba9 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 0c4c548 
>   core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 41e6732 
>   core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 64d4822 
>   core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 37a2f8b 
>   core/src/main/java/org/apache/oozie/command/wf/NotificationXCommand.java 651b5fd 
>   core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 5dd06ca 
>   core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 7b8ee3b 
>   core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 4a7283f 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java 5e9abcf 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 66baca1 
>   core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 635186a 
>   core/src/main/java/org/apache/oozie/service/CallableQueueService.java 093eb08 
>   core/src/main/java/org/apache/oozie/service/EventHandlerService.java 761537b 
>   core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java 541faca 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java f7458dc 
>   core/src/main/java/org/apache/oozie/util/LogUtils.java 814caff 
>   core/src/main/java/org/apache/oozie/util/XLog.java 31a5ba0 
>   core/src/test/java/org/apache/oozie/util/TestXLog.java 824e5dc 
> 
> Diff: https://reviews.apache.org/r/23968/diff/
> 
> 
> Testing
> -------
> 
> Done manual test.
> 
> 
> Thanks,
> 
> Azrael Park
> 
>

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

Posted by Azrael Park <az...@nexr.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23968/
-----------------------------------------------------------

(Updated Aug. 13, 2014, 7:32 a.m.)


Review request for oozie.


Changes
-------

Removed logInfo in XCommand.


Bugs: OOZIE-1939
    https://issues.apache.org/jira/browse/OOZIE-1939


Repository: oozie-git


Description
-------

Because of ThreadLocal, I added setLogInfo() at XCommand.
If the logInfo in setLogInfo() is enough, It might not need to set logInfo in loadState().


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 7f4d473 
  core/src/main/java/org/apache/oozie/command/XCommand.java 44e1133 
  core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 41ad8ae 
  core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 8ccab0e 
  core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 65eb272 
  core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java c101f45 
  core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java 0a04a02 
  core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java f5f4b3f 
  core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 74fbcab 
  core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08 
  core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java 5d6ef65 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 9ac66b2 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 0a9e4fa 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java 562b211 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java ffe85f0 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java c774f8e 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1ca055d 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 5a5bf98 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 6e3af70 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java ed85a40 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java d2b4659 
  core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java a2748c4 
  core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 91e9e09 
  core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef 
  core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java cc2127a 
  core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java ae71924 
  core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 735b295 
  core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 0aae1e6 
  core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef 
  core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java b1b2fcd 
  core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java a177101 
  core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java d6e47da 
  core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 39c522d 
  core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 42cb290 
  core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 863bf7d 
  core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java f3a4ba9 
  core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 0c4c548 
  core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 41e6732 
  core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 64d4822 
  core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 37a2f8b 
  core/src/main/java/org/apache/oozie/command/wf/NotificationXCommand.java 651b5fd 
  core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 5dd06ca 
  core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 7b8ee3b 
  core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 4a7283f 
  core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java 5e9abcf 
  core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 66baca1 
  core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 635186a 
  core/src/main/java/org/apache/oozie/service/CallableQueueService.java 093eb08 
  core/src/main/java/org/apache/oozie/service/EventHandlerService.java 761537b 
  core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java 541faca 
  core/src/main/java/org/apache/oozie/servlet/HostnameFilter.java afba9ec 
  core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java f7458dc 
  core/src/main/java/org/apache/oozie/util/LogUtils.java 814caff 
  core/src/main/java/org/apache/oozie/util/XLog.java 31a5ba0 
  core/src/test/java/org/apache/oozie/util/TestXLog.java 824e5dc 

Diff: https://reviews.apache.org/r/23968/diff/


Testing
-------

Done manual test.


Thanks,

Azrael Park

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

Posted by Azrael Park <az...@nexr.com>.


> On Aug. 13, 2014, 5:52 a.m., shwethags wrote:
> > core/src/main/java/org/apache/oozie/command/XCommand.java, line 97
> > <https://reviews.apache.org/r/23968/diff/6/?file=657467#file657467line97>
> >
> >     not required?

not required.


- Azrael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23968/#review50415
-----------------------------------------------------------


On Aug. 11, 2014, 7:02 a.m., Azrael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23968/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2014, 7:02 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1939
>     https://issues.apache.org/jira/browse/OOZIE-1939
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Because of ThreadLocal, I added setLogInfo() at XCommand.
> If the logInfo in setLogInfo() is enough, It might not need to set logInfo in loadState().
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf 
>   core/src/main/java/org/apache/oozie/command/XCommand.java 44e1133 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 41ad8ae 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 8ccab0e 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 65eb272 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java c101f45 
>   core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java 0a04a02 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java f5f4b3f 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 74fbcab 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java 5d6ef65 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 9ac66b2 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 0a9e4fa 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java 562b211 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java ffe85f0 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java c774f8e 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1ca055d 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 5a5bf98 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 6e3af70 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java ed85a40 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java d2b4659 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java a2748c4 
>   core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 91e9e09 
>   core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java cc2127a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java ae71924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 735b295 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 0aae1e6 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java b1b2fcd 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java a177101 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java d6e47da 
>   core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 39c522d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 42cb290 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 863bf7d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java f3a4ba9 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 0c4c548 
>   core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 41e6732 
>   core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 64d4822 
>   core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 37a2f8b 
>   core/src/main/java/org/apache/oozie/command/wf/NotificationXCommand.java 651b5fd 
>   core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 5dd06ca 
>   core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 7b8ee3b 
>   core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 4a7283f 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java 5e9abcf 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 66baca1 
>   core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 635186a 
>   core/src/main/java/org/apache/oozie/service/CallableQueueService.java 093eb08 
>   core/src/main/java/org/apache/oozie/service/EventHandlerService.java 761537b 
>   core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java 541faca 
>   core/src/main/java/org/apache/oozie/servlet/HostnameFilter.java afba9ec 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java f7458dc 
>   core/src/main/java/org/apache/oozie/util/LogUtils.java 814caff 
>   core/src/main/java/org/apache/oozie/util/XLog.java 31a5ba0 
>   core/src/test/java/org/apache/oozie/util/TestXLog.java 824e5dc 
> 
> Diff: https://reviews.apache.org/r/23968/diff/
> 
> 
> Testing
> -------
> 
> Done manual test.
> 
> 
> Thanks,
> 
> Azrael Park
> 
>

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

Posted by sh...@inmobi.com.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23968/#review50415
-----------------------------------------------------------

Ship it!


Minor comment


core/src/main/java/org/apache/oozie/command/XCommand.java
<https://reviews.apache.org/r/23968/#comment88185>

    not required?


- shwethags


On Aug. 11, 2014, 7:02 a.m., Azrael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23968/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2014, 7:02 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1939
>     https://issues.apache.org/jira/browse/OOZIE-1939
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Because of ThreadLocal, I added setLogInfo() at XCommand.
> If the logInfo in setLogInfo() is enough, It might not need to set logInfo in loadState().
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf 
>   core/src/main/java/org/apache/oozie/command/XCommand.java 44e1133 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 41ad8ae 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 8ccab0e 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 65eb272 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java c101f45 
>   core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java 0a04a02 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java f5f4b3f 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 74fbcab 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java 5d6ef65 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 9ac66b2 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 0a9e4fa 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java 562b211 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java ffe85f0 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java c774f8e 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1ca055d 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 5a5bf98 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 6e3af70 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java ed85a40 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java d2b4659 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java a2748c4 
>   core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 91e9e09 
>   core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java cc2127a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java ae71924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 735b295 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 0aae1e6 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java b1b2fcd 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java a177101 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java d6e47da 
>   core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 39c522d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 42cb290 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 863bf7d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java f3a4ba9 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 0c4c548 
>   core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 41e6732 
>   core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 64d4822 
>   core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 37a2f8b 
>   core/src/main/java/org/apache/oozie/command/wf/NotificationXCommand.java 651b5fd 
>   core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 5dd06ca 
>   core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 7b8ee3b 
>   core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 4a7283f 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java 5e9abcf 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 66baca1 
>   core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 635186a 
>   core/src/main/java/org/apache/oozie/service/CallableQueueService.java 093eb08 
>   core/src/main/java/org/apache/oozie/service/EventHandlerService.java 761537b 
>   core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java 541faca 
>   core/src/main/java/org/apache/oozie/servlet/HostnameFilter.java afba9ec 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java f7458dc 
>   core/src/main/java/org/apache/oozie/util/LogUtils.java 814caff 
>   core/src/main/java/org/apache/oozie/util/XLog.java 31a5ba0 
>   core/src/test/java/org/apache/oozie/util/TestXLog.java 824e5dc 
> 
> Diff: https://reviews.apache.org/r/23968/diff/
> 
> 
> Testing
> -------
> 
> Done manual test.
> 
> 
> Thanks,
> 
> Azrael Park
> 
>

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

Posted by Azrael Park <az...@nexr.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23968/
-----------------------------------------------------------

(Updated Aug. 11, 2014, 7:02 a.m.)


Review request for oozie.


Changes
-------

Address comments:
* clear() call resetPrefix().
* getting rid of setting XLog.prefix in constructor.


Bugs: OOZIE-1939
    https://issues.apache.org/jira/browse/OOZIE-1939


Repository: oozie-git


Description
-------

Because of ThreadLocal, I added setLogInfo() at XCommand.
If the logInfo in setLogInfo() is enough, It might not need to set logInfo in loadState().


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf 
  core/src/main/java/org/apache/oozie/command/XCommand.java 44e1133 
  core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 41ad8ae 
  core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 8ccab0e 
  core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 65eb272 
  core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java c101f45 
  core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java 0a04a02 
  core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java f5f4b3f 
  core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 74fbcab 
  core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08 
  core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java 5d6ef65 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 9ac66b2 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 0a9e4fa 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java 562b211 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java ffe85f0 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java c774f8e 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1ca055d 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 5a5bf98 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 6e3af70 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java ed85a40 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java d2b4659 
  core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java a2748c4 
  core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 91e9e09 
  core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef 
  core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java cc2127a 
  core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java ae71924 
  core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 735b295 
  core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 0aae1e6 
  core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef 
  core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java b1b2fcd 
  core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java a177101 
  core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java d6e47da 
  core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 39c522d 
  core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 42cb290 
  core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 863bf7d 
  core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java f3a4ba9 
  core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 0c4c548 
  core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 41e6732 
  core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 64d4822 
  core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 37a2f8b 
  core/src/main/java/org/apache/oozie/command/wf/NotificationXCommand.java 651b5fd 
  core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 5dd06ca 
  core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 7b8ee3b 
  core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 4a7283f 
  core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java 5e9abcf 
  core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 66baca1 
  core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 635186a 
  core/src/main/java/org/apache/oozie/service/CallableQueueService.java 093eb08 
  core/src/main/java/org/apache/oozie/service/EventHandlerService.java 761537b 
  core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java 541faca 
  core/src/main/java/org/apache/oozie/servlet/HostnameFilter.java afba9ec 
  core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java f7458dc 
  core/src/main/java/org/apache/oozie/util/LogUtils.java 814caff 
  core/src/main/java/org/apache/oozie/util/XLog.java 31a5ba0 
  core/src/test/java/org/apache/oozie/util/TestXLog.java 824e5dc 

Diff: https://reviews.apache.org/r/23968/diff/


Testing
-------

Done manual test.


Thanks,

Azrael Park

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

Posted by Azrael Park <az...@nexr.com>.


> On Aug. 8, 2014, 8:37 a.m., shwethags wrote:
> > core/src/main/java/org/apache/oozie/servlet/HostnameFilter.java, line 84
> > <https://reviews.apache.org/r/23968/diff/5/?file=656500#file656500line84>
> >
> >     clear() should also resetPrefix? else, log() will use the old prefix

Yes, will call resetPrefix.


- Azrael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23968/#review50020
-----------------------------------------------------------


On Aug. 8, 2014, 5:31 a.m., Azrael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23968/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2014, 5:31 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1939
>     https://issues.apache.org/jira/browse/OOZIE-1939
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Because of ThreadLocal, I added setLogInfo() at XCommand.
> If the logInfo in setLogInfo() is enough, It might not need to set logInfo in loadState().
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf 
>   core/src/main/java/org/apache/oozie/command/XCommand.java 44e1133 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 41ad8ae 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 8ccab0e 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 65eb272 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java c101f45 
>   core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java 0a04a02 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java f5f4b3f 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 74fbcab 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java 5d6ef65 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 9ac66b2 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 0a9e4fa 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java 562b211 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java ffe85f0 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java c774f8e 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1ca055d 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 5a5bf98 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 6e3af70 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java ed85a40 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java d2b4659 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java a2748c4 
>   core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 91e9e09 
>   core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java cc2127a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java ae71924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 735b295 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 0aae1e6 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java b1b2fcd 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java a177101 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java d6e47da 
>   core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 39c522d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 42cb290 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 863bf7d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java f3a4ba9 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 0c4c548 
>   core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 41e6732 
>   core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 64d4822 
>   core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 37a2f8b 
>   core/src/main/java/org/apache/oozie/command/wf/NotificationXCommand.java 651b5fd 
>   core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 5dd06ca 
>   core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 7b8ee3b 
>   core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 4a7283f 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java 5e9abcf 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 66baca1 
>   core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 635186a 
>   core/src/main/java/org/apache/oozie/service/CallableQueueService.java 093eb08 
>   core/src/main/java/org/apache/oozie/service/EventHandlerService.java 761537b 
>   core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java 541faca 
>   core/src/main/java/org/apache/oozie/servlet/HostnameFilter.java afba9ec 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java f7458dc 
>   core/src/main/java/org/apache/oozie/util/LogUtils.java 814caff 
>   core/src/main/java/org/apache/oozie/util/XLog.java 31a5ba0 
>   core/src/test/java/org/apache/oozie/util/TestXLog.java 824e5dc 
> 
> Diff: https://reviews.apache.org/r/23968/diff/
> 
> 
> Testing
> -------
> 
> Done manual test.
> 
> 
> Thanks,
> 
> Azrael Park
> 
>

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

Posted by Azrael Park <az...@nexr.com>.


> On Aug. 8, 2014, 8:37 a.m., shwethags wrote:
> > core/src/main/java/org/apache/oozie/util/XLog.java, line 533
> > <https://reviews.apache.org/r/23968/diff/5/?file=656503#file656503line533>
> >
> >     JsonRestServlet has this code:
> >             auditLog.setMsgPrefix("");
> >     
> >     audit log logs using XLog but doesn't use XLog.Info.prefix. To support that, we might have to use XLog.prefix as well. 
> >     
> >     In all XLog constructors, can we get rid of setting XLog.prefix. XLog.setMsgPrefix() can just set XLog.prefix without null check. XLog.log() can then use XLog.prefix if not null else use Info.get().getPrefix(). With this, since the class loggers don't set prefix, they always use Info.get().getPrefix(). Audit log sets XLog.prefix, so it never uses Info.get().getPrefix()

Ok


- Azrael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23968/#review50020
-----------------------------------------------------------


On Aug. 8, 2014, 5:31 a.m., Azrael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23968/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2014, 5:31 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1939
>     https://issues.apache.org/jira/browse/OOZIE-1939
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Because of ThreadLocal, I added setLogInfo() at XCommand.
> If the logInfo in setLogInfo() is enough, It might not need to set logInfo in loadState().
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf 
>   core/src/main/java/org/apache/oozie/command/XCommand.java 44e1133 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 41ad8ae 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 8ccab0e 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 65eb272 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java c101f45 
>   core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java 0a04a02 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java f5f4b3f 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 74fbcab 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java 5d6ef65 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 9ac66b2 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 0a9e4fa 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java 562b211 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java ffe85f0 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java c774f8e 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1ca055d 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 5a5bf98 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 6e3af70 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java ed85a40 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java d2b4659 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java a2748c4 
>   core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 91e9e09 
>   core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java cc2127a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java ae71924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 735b295 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 0aae1e6 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java b1b2fcd 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java a177101 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java d6e47da 
>   core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 39c522d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 42cb290 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 863bf7d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java f3a4ba9 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 0c4c548 
>   core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 41e6732 
>   core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 64d4822 
>   core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 37a2f8b 
>   core/src/main/java/org/apache/oozie/command/wf/NotificationXCommand.java 651b5fd 
>   core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 5dd06ca 
>   core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 7b8ee3b 
>   core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 4a7283f 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java 5e9abcf 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 66baca1 
>   core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 635186a 
>   core/src/main/java/org/apache/oozie/service/CallableQueueService.java 093eb08 
>   core/src/main/java/org/apache/oozie/service/EventHandlerService.java 761537b 
>   core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java 541faca 
>   core/src/main/java/org/apache/oozie/servlet/HostnameFilter.java afba9ec 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java f7458dc 
>   core/src/main/java/org/apache/oozie/util/LogUtils.java 814caff 
>   core/src/main/java/org/apache/oozie/util/XLog.java 31a5ba0 
>   core/src/test/java/org/apache/oozie/util/TestXLog.java 824e5dc 
> 
> Diff: https://reviews.apache.org/r/23968/diff/
> 
> 
> Testing
> -------
> 
> Done manual test.
> 
> 
> Thanks,
> 
> Azrael Park
> 
>

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

Posted by sh...@inmobi.com.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23968/#review50020
-----------------------------------------------------------


+1 with some minor comments


core/src/main/java/org/apache/oozie/servlet/HostnameFilter.java
<https://reviews.apache.org/r/23968/#comment87529>

    clear() should also resetPrefix? else, log() will use the old prefix



core/src/main/java/org/apache/oozie/util/XLog.java
<https://reviews.apache.org/r/23968/#comment87532>

    JsonRestServlet has this code:
            auditLog.setMsgPrefix("");
    
    audit log logs using XLog but doesn't use XLog.Info.prefix. To support that, we might have to use XLog.prefix as well. 
    
    In all XLog constructors, can we get rid of setting XLog.prefix. XLog.setMsgPrefix() can just set XLog.prefix without null check. XLog.log() can then use XLog.prefix if not null else use Info.get().getPrefix(). With this, since the class loggers don't set prefix, they always use Info.get().getPrefix(). Audit log sets XLog.prefix, so it never uses Info.get().getPrefix()


- shwethags


On Aug. 8, 2014, 5:31 a.m., Azrael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23968/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2014, 5:31 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1939
>     https://issues.apache.org/jira/browse/OOZIE-1939
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Because of ThreadLocal, I added setLogInfo() at XCommand.
> If the logInfo in setLogInfo() is enough, It might not need to set logInfo in loadState().
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf 
>   core/src/main/java/org/apache/oozie/command/XCommand.java 44e1133 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 41ad8ae 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 8ccab0e 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 65eb272 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java c101f45 
>   core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java 0a04a02 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java f5f4b3f 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 74fbcab 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java 5d6ef65 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 9ac66b2 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 0a9e4fa 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java 562b211 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java ffe85f0 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java c774f8e 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1ca055d 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 5a5bf98 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 6e3af70 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java ed85a40 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java d2b4659 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java a2748c4 
>   core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 91e9e09 
>   core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java cc2127a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java ae71924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 735b295 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 0aae1e6 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java b1b2fcd 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java a177101 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java d6e47da 
>   core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 39c522d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 42cb290 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 863bf7d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java f3a4ba9 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 0c4c548 
>   core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 41e6732 
>   core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 64d4822 
>   core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 37a2f8b 
>   core/src/main/java/org/apache/oozie/command/wf/NotificationXCommand.java 651b5fd 
>   core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 5dd06ca 
>   core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 7b8ee3b 
>   core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 4a7283f 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java 5e9abcf 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 66baca1 
>   core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 635186a 
>   core/src/main/java/org/apache/oozie/service/CallableQueueService.java 093eb08 
>   core/src/main/java/org/apache/oozie/service/EventHandlerService.java 761537b 
>   core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java 541faca 
>   core/src/main/java/org/apache/oozie/servlet/HostnameFilter.java afba9ec 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java f7458dc 
>   core/src/main/java/org/apache/oozie/util/LogUtils.java 814caff 
>   core/src/main/java/org/apache/oozie/util/XLog.java 31a5ba0 
>   core/src/test/java/org/apache/oozie/util/TestXLog.java 824e5dc 
> 
> Diff: https://reviews.apache.org/r/23968/diff/
> 
> 
> Testing
> -------
> 
> Done manual test.
> 
> 
> Thanks,
> 
> Azrael Park
> 
>

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

Posted by Azrael Park <az...@nexr.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23968/
-----------------------------------------------------------

(Updated Aug. 8, 2014, 5:31 a.m.)


Review request for oozie.


Changes
-------

Add resetPrefix() on LogInfo and in XLog.log(), get this prefix.


Bugs: OOZIE-1939
    https://issues.apache.org/jira/browse/OOZIE-1939


Repository: oozie-git


Description
-------

Because of ThreadLocal, I added setLogInfo() at XCommand.
If the logInfo in setLogInfo() is enough, It might not need to set logInfo in loadState().


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf 
  core/src/main/java/org/apache/oozie/command/XCommand.java 44e1133 
  core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 41ad8ae 
  core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 8ccab0e 
  core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 65eb272 
  core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java c101f45 
  core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java 0a04a02 
  core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java f5f4b3f 
  core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 74fbcab 
  core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08 
  core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java 5d6ef65 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 9ac66b2 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 0a9e4fa 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java 562b211 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java ffe85f0 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java c774f8e 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1ca055d 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 5a5bf98 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 6e3af70 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java ed85a40 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java d2b4659 
  core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java a2748c4 
  core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 91e9e09 
  core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef 
  core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java cc2127a 
  core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java ae71924 
  core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 735b295 
  core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 0aae1e6 
  core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef 
  core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java b1b2fcd 
  core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java a177101 
  core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java d6e47da 
  core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 39c522d 
  core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 42cb290 
  core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 863bf7d 
  core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java f3a4ba9 
  core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 0c4c548 
  core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 41e6732 
  core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 64d4822 
  core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 37a2f8b 
  core/src/main/java/org/apache/oozie/command/wf/NotificationXCommand.java 651b5fd 
  core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 5dd06ca 
  core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 7b8ee3b 
  core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 4a7283f 
  core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java 5e9abcf 
  core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 66baca1 
  core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 635186a 
  core/src/main/java/org/apache/oozie/service/CallableQueueService.java 093eb08 
  core/src/main/java/org/apache/oozie/service/EventHandlerService.java 761537b 
  core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java 541faca 
  core/src/main/java/org/apache/oozie/servlet/HostnameFilter.java afba9ec 
  core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java f7458dc 
  core/src/main/java/org/apache/oozie/util/LogUtils.java 814caff 
  core/src/main/java/org/apache/oozie/util/XLog.java 31a5ba0 
  core/src/test/java/org/apache/oozie/util/TestXLog.java 824e5dc 

Diff: https://reviews.apache.org/r/23968/diff/


Testing
-------

Done manual test.


Thanks,

Azrael Park

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

Posted by Azrael Park <az...@nexr.com>.


> On Aug. 7, 2014, 8:30 a.m., shwethags wrote:
> > core/src/main/java/org/apache/oozie/util/LogUtils.java, line 52
> > <https://reviews.apache.org/r/23968/diff/4/?file=653630#file653630line52>
> >
> >     resetPrefix() on XLog doesn't work as XLog is shared across threads, so log() shouldn't even use XLog.prefix(with the exception for audit log which doesn't use thread level prefix). What you need is resetPrefix() on LogInfo which re-computes prefix and stores in some variable. log() should use this prefix

Yes, will fix.


- Azrael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23968/#review49873
-----------------------------------------------------------


On Aug. 6, 2014, 6:40 a.m., Azrael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23968/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2014, 6:40 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1939
>     https://issues.apache.org/jira/browse/OOZIE-1939
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Because of ThreadLocal, I added setLogInfo() at XCommand.
> If the logInfo in setLogInfo() is enough, It might not need to set logInfo in loadState().
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf 
>   core/src/main/java/org/apache/oozie/command/XCommand.java 44e1133 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 41ad8ae 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 8ccab0e 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 65eb272 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java c101f45 
>   core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java 0a04a02 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java f5f4b3f 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 74fbcab 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java 5d6ef65 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 9ac66b2 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 0a9e4fa 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java 562b211 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java ffe85f0 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java c774f8e 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1ca055d 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 5a5bf98 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 6e3af70 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java ed85a40 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java d2b4659 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java a2748c4 
>   core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 91e9e09 
>   core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java cc2127a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java ae71924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 735b295 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 0aae1e6 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java b1b2fcd 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java a177101 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java d6e47da 
>   core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 39c522d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 42cb290 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 863bf7d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java f3a4ba9 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 0c4c548 
>   core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 41e6732 
>   core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 64d4822 
>   core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 37a2f8b 
>   core/src/main/java/org/apache/oozie/command/wf/NotificationXCommand.java 651b5fd 
>   core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 5dd06ca 
>   core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 7b8ee3b 
>   core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 4a7283f 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java 5e9abcf 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 66baca1 
>   core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 635186a 
>   core/src/main/java/org/apache/oozie/service/CallableQueueService.java 093eb08 
>   core/src/main/java/org/apache/oozie/service/EventHandlerService.java 761537b 
>   core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java 541faca 
>   core/src/main/java/org/apache/oozie/servlet/HostnameFilter.java afba9ec 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java f7458dc 
>   core/src/main/java/org/apache/oozie/util/LogUtils.java 814caff 
>   core/src/test/java/org/apache/oozie/util/TestXLog.java 824e5dc 
> 
> Diff: https://reviews.apache.org/r/23968/diff/
> 
> 
> Testing
> -------
> 
> Done manual test.
> 
> 
> Thanks,
> 
> Azrael Park
> 
>

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

Posted by sh...@inmobi.com.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23968/#review49873
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/util/LogUtils.java
<https://reviews.apache.org/r/23968/#comment87276>

    resetPrefix() on XLog doesn't work as XLog is shared across threads, so log() shouldn't even use XLog.prefix(with the exception for audit log which doesn't use thread level prefix). What you need is resetPrefix() on LogInfo which re-computes prefix and stores in some variable. log() should use this prefix


- shwethags


On Aug. 6, 2014, 6:40 a.m., Azrael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23968/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2014, 6:40 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1939
>     https://issues.apache.org/jira/browse/OOZIE-1939
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Because of ThreadLocal, I added setLogInfo() at XCommand.
> If the logInfo in setLogInfo() is enough, It might not need to set logInfo in loadState().
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf 
>   core/src/main/java/org/apache/oozie/command/XCommand.java 44e1133 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 41ad8ae 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 8ccab0e 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 65eb272 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java c101f45 
>   core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java 0a04a02 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java f5f4b3f 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 74fbcab 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java 5d6ef65 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 9ac66b2 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 0a9e4fa 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java 562b211 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java ffe85f0 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java c774f8e 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1ca055d 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 5a5bf98 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 6e3af70 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java ed85a40 
>   core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java d2b4659 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java a2748c4 
>   core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 91e9e09 
>   core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java cc2127a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java ae71924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 735b295 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 0aae1e6 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java b1b2fcd 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java a177101 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java d6e47da 
>   core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 39c522d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 42cb290 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 863bf7d 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java f3a4ba9 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 0c4c548 
>   core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 41e6732 
>   core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 64d4822 
>   core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 37a2f8b 
>   core/src/main/java/org/apache/oozie/command/wf/NotificationXCommand.java 651b5fd 
>   core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 5dd06ca 
>   core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 7b8ee3b 
>   core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 4a7283f 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java 5e9abcf 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 66baca1 
>   core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 635186a 
>   core/src/main/java/org/apache/oozie/service/CallableQueueService.java 093eb08 
>   core/src/main/java/org/apache/oozie/service/EventHandlerService.java 761537b 
>   core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java 541faca 
>   core/src/main/java/org/apache/oozie/servlet/HostnameFilter.java afba9ec 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java f7458dc 
>   core/src/main/java/org/apache/oozie/util/LogUtils.java 814caff 
>   core/src/test/java/org/apache/oozie/util/TestXLog.java 824e5dc 
> 
> Diff: https://reviews.apache.org/r/23968/diff/
> 
> 
> Testing
> -------
> 
> Done manual test.
> 
> 
> Thanks,
> 
> Azrael Park
> 
>

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

Posted by Azrael Park <az...@nexr.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23968/
-----------------------------------------------------------

(Updated Aug. 6, 2014, 6:40 a.m.)


Review request for oozie.


Changes
-------

Address comments.
* Remove redundant code in beforeExecute().
* Remove afterExecute().
* Store prefix in LogUtils.setLogInfo() and use it XLog.log().
* Clear log info for the tomcat threadpool.


Bugs: OOZIE-1939
    https://issues.apache.org/jira/browse/OOZIE-1939


Repository: oozie-git


Description
-------

Because of ThreadLocal, I added setLogInfo() at XCommand.
If the logInfo in setLogInfo() is enough, It might not need to set logInfo in loadState().


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf 
  core/src/main/java/org/apache/oozie/command/XCommand.java 44e1133 
  core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 41ad8ae 
  core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 8ccab0e 
  core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 65eb272 
  core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java c101f45 
  core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java 0a04a02 
  core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java f5f4b3f 
  core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 74fbcab 
  core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08 
  core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java 5d6ef65 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 9ac66b2 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 0a9e4fa 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java 562b211 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java ffe85f0 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java c774f8e 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1ca055d 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 5a5bf98 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 6e3af70 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java ed85a40 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java d2b4659 
  core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java a2748c4 
  core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 91e9e09 
  core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef 
  core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java cc2127a 
  core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java ae71924 
  core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 735b295 
  core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 0aae1e6 
  core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef 
  core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java b1b2fcd 
  core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java a177101 
  core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java d6e47da 
  core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 39c522d 
  core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 42cb290 
  core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 863bf7d 
  core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java f3a4ba9 
  core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 0c4c548 
  core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 41e6732 
  core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 64d4822 
  core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 37a2f8b 
  core/src/main/java/org/apache/oozie/command/wf/NotificationXCommand.java 651b5fd 
  core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 5dd06ca 
  core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 7b8ee3b 
  core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 4a7283f 
  core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java 5e9abcf 
  core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 66baca1 
  core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 635186a 
  core/src/main/java/org/apache/oozie/service/CallableQueueService.java 093eb08 
  core/src/main/java/org/apache/oozie/service/EventHandlerService.java 761537b 
  core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java 541faca 
  core/src/main/java/org/apache/oozie/servlet/HostnameFilter.java afba9ec 
  core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java f7458dc 
  core/src/main/java/org/apache/oozie/util/LogUtils.java 814caff 
  core/src/test/java/org/apache/oozie/util/TestXLog.java 824e5dc 

Diff: https://reviews.apache.org/r/23968/diff/


Testing
-------

Done manual test.


Thanks,

Azrael Park

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

Posted by Azrael Park <az...@nexr.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23968/
-----------------------------------------------------------

(Updated Aug. 5, 2014, 7:49 a.m.)


Review request for oozie.


Changes
-------

ThreadPoolExecutor override beforeExecute() method.
In XLog.log(), prefix computed as thread local log info.

As the comment, ThreadPoolExecutor override beforeExecute() method to reset the log info.
The CompositeCallable contains different log info and the syncAction execution cause the change of log info. So, the context depends on XCommand(jobId, actionId) should be reset. Hence, IMO, this overriding might be duplicated code and be removed.


Bugs: OOZIE-1939
    https://issues.apache.org/jira/browse/OOZIE-1939


Repository: oozie-git


Description
-------

Because of ThreadLocal, I added setLogInfo() at XCommand.
If the logInfo in setLogInfo() is enough, It might not need to set logInfo in loadState().


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf 
  core/src/main/java/org/apache/oozie/command/XCommand.java 44e1133 
  core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 41ad8ae 
  core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 8ccab0e 
  core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 65eb272 
  core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java c101f45 
  core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java 0a04a02 
  core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java f5f4b3f 
  core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 74fbcab 
  core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08 
  core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java 5d6ef65 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 9ac66b2 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 0a9e4fa 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java 562b211 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java ffe85f0 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java c774f8e 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1ca055d 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 5a5bf98 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 6e3af70 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java ed85a40 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java d2b4659 
  core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java a2748c4 
  core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 91e9e09 
  core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef 
  core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java cc2127a 
  core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java ae71924 
  core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 735b295 
  core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 0aae1e6 
  core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef 
  core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java b1b2fcd 
  core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java a177101 
  core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java d6e47da 
  core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 39c522d 
  core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 42cb290 
  core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 863bf7d 
  core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java f3a4ba9 
  core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 0c4c548 
  core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 41e6732 
  core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 64d4822 
  core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 37a2f8b 
  core/src/main/java/org/apache/oozie/command/wf/NotificationXCommand.java 651b5fd 
  core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 5dd06ca 
  core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 7b8ee3b 
  core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 4a7283f 
  core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java 5e9abcf 
  core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 66baca1 
  core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 635186a 
  core/src/main/java/org/apache/oozie/service/CallableQueueService.java 093eb08 
  core/src/main/java/org/apache/oozie/service/EventHandlerService.java 761537b 
  core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java 541faca 
  core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java f7458dc 
  core/src/main/java/org/apache/oozie/util/LogUtils.java 814caff 
  core/src/main/java/org/apache/oozie/util/XLog.java 31a5ba0 
  core/src/test/java/org/apache/oozie/util/TestXLog.java 824e5dc 

Diff: https://reviews.apache.org/r/23968/diff/


Testing
-------

Done manual test.


Thanks,

Azrael Park

Re: Review Request 23968: OOZIE-1939 Incorrect job information is set while logging

Posted by Azrael Park <az...@nexr.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23968/
-----------------------------------------------------------

(Updated July 31, 2014, 6 p.m.)


Review request for oozie.


Changes
-------

Address comment.


Bugs: OOZIE-1939
    https://issues.apache.org/jira/browse/OOZIE-1939


Repository: oozie-git


Description
-------

Because of ThreadLocal, I added setLogInfo() at XCommand.
If the logInfo in setLogInfo() is enough, It might not need to set logInfo in loadState().


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf 
  core/src/main/java/org/apache/oozie/command/XCommand.java 44e1133 
  core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 41ad8ae 
  core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 8ccab0e 
  core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 65eb272 
  core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java c101f45 
  core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java 0a04a02 
  core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java f5f4b3f 
  core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 74fbcab 
  core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java ffb2d08 
  core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java 5d6ef65 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 9ac66b2 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 0a9e4fa 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java 562b211 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java ffe85f0 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java c774f8e 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1ca055d 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 5a5bf98 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 6e3af70 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java ed85a40 
  core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java d2b4659 
  core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java a2748c4 
  core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 91e9e09 
  core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java b4b2fef 
  core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java cc2127a 
  core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java ae71924 
  core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 735b295 
  core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 0aae1e6 
  core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 02b30ef 
  core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java b1b2fcd 
  core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java a177101 
  core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java d6e47da 
  core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 39c522d 
  core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 42cb290 
  core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 863bf7d 
  core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java f3a4ba9 
  core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 0c4c548 
  core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 41e6732 
  core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java 64d4822 
  core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 37a2f8b 
  core/src/main/java/org/apache/oozie/command/wf/NotificationXCommand.java 651b5fd 
  core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 5dd06ca 
  core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 7b8ee3b 
  core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 4a7283f 
  core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java 5e9abcf 
  core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 66baca1 
  core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 635186a 
  core/src/main/java/org/apache/oozie/util/LogUtils.java 814caff 
  core/src/test/java/org/apache/oozie/util/TestXLog.java 824e5dc 

Diff: https://reviews.apache.org/r/23968/diff/


Testing
-------

Done manual test.


Thanks,

Azrael Park