You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/28 21:59:47 UTC
[GitHub] [arrow] pachadotdev opened a new pull request #10613: Arrow12967v2
pachadotdev opened a new pull request #10613:
URL: https://github.com/apache/arrow/pull/10613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10613: Arrow12967v2
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10613:
URL: https://github.com/apache/arrow/pull/10613#issuecomment-870073001
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pachadotdev commented on a change in pull request #10613: ARROW-12967: [R] Add bindings for pmin() and pmax() #10497
Posted by GitBox <gi...@apache.org>.
pachadotdev commented on a change in pull request #10613:
URL: https://github.com/apache/arrow/pull/10613#discussion_r660146504
##########
File path: r/R/dplyr-functions.R
##########
@@ -519,16 +535,16 @@ nse_funcs$second <- function(x) {
# providing offset values based on the specified week_start day, and adding 1
# so the returned value is 1-indexed instead of 0-indexed.
nse_funcs$wday <- function(x, label = FALSE, abbr = TRUE, week_start = getOption("lubridate.week.start", 7)) {
-
+
Review comment:
space
##########
File path: r/R/dplyr-functions.R
##########
@@ -519,16 +535,16 @@ nse_funcs$second <- function(x) {
# providing offset values based on the specified week_start day, and adding 1
# so the returned value is 1-indexed instead of 0-indexed.
nse_funcs$wday <- function(x, label = FALSE, abbr = TRUE, week_start = getOption("lubridate.week.start", 7)) {
-
+
# The "day_of_week" compute function returns numeric days of week and not locale-aware strftime
# When the ticket below is resolved, we should be able to support the label argument
# https://issues.apache.org/jira/browse/ARROW-13133
if (label) {
arrow_not_supported("Label argument")
}
-
+
# overall formula to convert from arrow::wday to lubridate::wday is:
# ((wday(day) - start + 8) %% 7) + 1
((Expression$create("day_of_week", x) - Expression$scalar(week_start) + 8) %% 7) + 1
-
+
Review comment:
space
##########
File path: r/R/dplyr-functions.R
##########
@@ -519,16 +535,16 @@ nse_funcs$second <- function(x) {
# providing offset values based on the specified week_start day, and adding 1
# so the returned value is 1-indexed instead of 0-indexed.
nse_funcs$wday <- function(x, label = FALSE, abbr = TRUE, week_start = getOption("lubridate.week.start", 7)) {
-
+
# The "day_of_week" compute function returns numeric days of week and not locale-aware strftime
# When the ticket below is resolved, we should be able to support the label argument
# https://issues.apache.org/jira/browse/ARROW-13133
if (label) {
arrow_not_supported("Label argument")
}
-
+
Review comment:
space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pachadotdev commented on pull request #10613: ARROW-12967: [R] Add bindings for pmin() and pmax() #10497
Posted by GitBox <gi...@apache.org>.
pachadotdev commented on pull request #10613:
URL: https://github.com/apache/arrow/pull/10613#issuecomment-870148994
autotune was more problematic... trying in a new PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pachadotdev commented on pull request #10613: ARROW-12967: [R] Add bindings for pmin() and pmax() #10497
Posted by GitBox <gi...@apache.org>.
pachadotdev commented on pull request #10613:
URL: https://github.com/apache/arrow/pull/10613#issuecomment-870109235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pachadotdev commented on a change in pull request #10613: ARROW-12967: [R] Add bindings for pmin() and pmax() #10497
Posted by GitBox <gi...@apache.org>.
pachadotdev commented on a change in pull request #10613:
URL: https://github.com/apache/arrow/pull/10613#discussion_r660146504
##########
File path: r/R/dplyr-functions.R
##########
@@ -519,16 +535,16 @@ nse_funcs$second <- function(x) {
# providing offset values based on the specified week_start day, and adding 1
# so the returned value is 1-indexed instead of 0-indexed.
nse_funcs$wday <- function(x, label = FALSE, abbr = TRUE, week_start = getOption("lubridate.week.start", 7)) {
-
+
Review comment:
space
##########
File path: r/R/dplyr-functions.R
##########
@@ -519,16 +535,16 @@ nse_funcs$second <- function(x) {
# providing offset values based on the specified week_start day, and adding 1
# so the returned value is 1-indexed instead of 0-indexed.
nse_funcs$wday <- function(x, label = FALSE, abbr = TRUE, week_start = getOption("lubridate.week.start", 7)) {
-
+
# The "day_of_week" compute function returns numeric days of week and not locale-aware strftime
# When the ticket below is resolved, we should be able to support the label argument
# https://issues.apache.org/jira/browse/ARROW-13133
if (label) {
arrow_not_supported("Label argument")
}
-
+
# overall formula to convert from arrow::wday to lubridate::wday is:
# ((wday(day) - start + 8) %% 7) + 1
((Expression$create("day_of_week", x) - Expression$scalar(week_start) + 8) %% 7) + 1
-
+
Review comment:
space
##########
File path: r/R/dplyr-functions.R
##########
@@ -519,16 +535,16 @@ nse_funcs$second <- function(x) {
# providing offset values based on the specified week_start day, and adding 1
# so the returned value is 1-indexed instead of 0-indexed.
nse_funcs$wday <- function(x, label = FALSE, abbr = TRUE, week_start = getOption("lubridate.week.start", 7)) {
-
+
# The "day_of_week" compute function returns numeric days of week and not locale-aware strftime
# When the ticket below is resolved, we should be able to support the label argument
# https://issues.apache.org/jira/browse/ARROW-13133
if (label) {
arrow_not_supported("Label argument")
}
-
+
Review comment:
space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pachadotdev closed pull request #10613: ARROW-12967: [R] Add bindings for pmin() and pmax() #10497
Posted by GitBox <gi...@apache.org>.
pachadotdev closed pull request #10613:
URL: https://github.com/apache/arrow/pull/10613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pachadotdev commented on pull request #10613: ARROW-12967: [R] Add bindings for pmin() and pmax() #10497
Posted by GitBox <gi...@apache.org>.
pachadotdev commented on pull request #10613:
URL: https://github.com/apache/arrow/pull/10613#issuecomment-870109235
@github-actions autotune
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10613: Arrow12967v2
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10613:
URL: https://github.com/apache/arrow/pull/10613#issuecomment-870073001
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pachadotdev closed pull request #10613: ARROW-12967: [R] Add bindings for pmin() and pmax() #10497
Posted by GitBox <gi...@apache.org>.
pachadotdev closed pull request #10613:
URL: https://github.com/apache/arrow/pull/10613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org