You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by Ohad Shacham <oh...@yahoo-inc.com> on 2017/02/09 14:52:05 UTC

Review Request 56498: PHOENIX-3656 Define a transaction abstraction layer

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56498/
-----------------------------------------------------------

Review request for phoenix.


Repository: phoenix


Description
-------

Currently Tephra calls are integrated inside Phoenix code. Therefore, in order to support both Omid and Tephra, we need to add another abstraction layer that later-on will be connected to both Tephra and Omid.


Diffs
-----

  phoenix-core/src/main/java/org/apache/phoenix/transaction/OmidTransactionContext.java PRE-CREATION 
  phoenix-core/src/main/java/org/apache/phoenix/transaction/OmidTransactionTable.java PRE-CREATION 
  phoenix-core/src/main/java/org/apache/phoenix/transaction/PhoenixTransactionContext.java PRE-CREATION 
  phoenix-core/src/main/java/org/apache/phoenix/transaction/PhoenixTransactionalTable.java PRE-CREATION 
  phoenix-core/src/main/java/org/apache/phoenix/transaction/TephraTransactionContext.java PRE-CREATION 
  phoenix-core/src/main/java/org/apache/phoenix/transaction/TephraTransactionTable.java PRE-CREATION 

Diff: https://reviews.apache.org/r/56498/diff/


Testing
-------


Thanks,

Ohad Shacham


Re: Review Request 56498: PHOENIX-3656 Define a transaction abstraction layer

Posted by Ohad Shacham via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56498/
-----------------------------------------------------------

(Updated March 6, 2017, 3:16 p.m.)


Review request for phoenix.


Changes
-------

Change PhoenixTransactionalTable to inherit from HTableInterface.


Repository: phoenix


Description
-------

Currently Tephra calls are integrated inside Phoenix code. Therefore, in order to support both Omid and Tephra, we need to add another abstraction layer that later-on will be connected to both Tephra and Omid.


Diffs (updated)
-----

  phoenix-core/src/main/java/org/apache/phoenix/transaction/OmidTransactionContext.java PRE-CREATION 
  phoenix-core/src/main/java/org/apache/phoenix/transaction/OmidTransactionTable.java PRE-CREATION 
  phoenix-core/src/main/java/org/apache/phoenix/transaction/PhoenixTransactionContext.java PRE-CREATION 
  phoenix-core/src/main/java/org/apache/phoenix/transaction/PhoenixTransactionalTable.java PRE-CREATION 
  phoenix-core/src/main/java/org/apache/phoenix/transaction/TephraTransactionContext.java PRE-CREATION 
  phoenix-core/src/main/java/org/apache/phoenix/transaction/TephraTransactionTable.java PRE-CREATION 


Diff: https://reviews.apache.org/r/56498/diff/2/

Changes: https://reviews.apache.org/r/56498/diff/1-2/


Testing
-------


Thanks,

Ohad Shacham