You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/02/24 18:27:29 UTC

[GitHub] [calcite-avatica] asolimando commented on pull request #138: [CALCITE-2489] Order of fields in JavaTypeFactoryImpl#createStructTyp…

asolimando commented on pull request #138:
URL: https://github.com/apache/calcite-avatica/pull/138#issuecomment-785280885


   I realized that there were no tests in Avatica specifically covering the lines changed by the PR.
   Even if the changed code is validated indirectly by the Calcite tests, I felt it was better to have unit-tests in Avatica too for that, the last commit adds them.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org