[GitHub] [pulsar] codelipenghui commented on a change in pull request #6758: change test case code org.apache.pulsar.io.PulsarFunctionE2ETest#testFunctionAutomaticSubCleanup

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #6758:
URL: https://github.com/apache/pulsar/pull/6758#discussion_r421265145



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
##########
@@ -2595,7 +2595,7 @@ protected void internalSetOffloadPolicies(AsyncResponse asyncResponse, OffloadPo
             final String path = path(POLICIES, namespaceName.toString());
             byte[] content = globalZk().getData(path, null, nodeStat);
             Policies policies = jsonMapper().readValue(content, Policies.class);
-
+            // there is possibility that `offloadPolicies.getManagedLedgerOffloadDeletionLagInMillis()` is null.

Review comment:
       Shall we need to add this comment? look we already have a null check for deletion lag.

##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarFunctionE2ETest.java
##########
@@ -1509,8 +1513,9 @@ public void testFunctionAutomaticSubCleanup() throws Exception {
 
         retryStrategically((test) -> {
             try {
+                // should remove `result.getParallelism() == 2` because the parallelism here should 1
                 FunctionConfig result = admin.functions().getFunction(tenant, namespacePortion, functionName);
-                return result.getParallelism() == 2 && result.getCleanupSubscription() == false;
+                return /*result.getParallelism() == 2 &&*/ result.getCleanupSubscription() == false;

Review comment:
       You can fix the wrong assert directly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org