[GitHub] [airflow] mik-laj commented on a change in pull request #8213: Fix issue #8163 where gcp auth fails

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #8213: Fix issue #8163 where gcp auth fails
URL: https://github.com/apache/airflow/pull/8213#discussion_r405501707
 
 

 ##########
 File path: airflow/providers/google/cloud/utils/credentials_provider.py
 ##########
 @@ -241,7 +241,14 @@ def get_credentials_and_project_id(
         project_id = credentials.project_id
 
     if delegate_to:
-        credentials = credentials.with_subject(delegate_to)
+        if hasattr(credentials, 'with_subject'):
+            credentials = credentials.with_subject(delegate_to)
+        else:
+            log.warning(
 
 Review comment:
   I think it would be a better idea to raise an exception to make the user more aware of this issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services