You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/07 20:02:05 UTC

[GitHub] [camel-kafka-connector] valdar edited a comment on pull request #428: Proposed fix for issue #414

valdar edited a comment on pull request #428:
URL: https://github.com/apache/camel-kafka-connector/pull/428#issuecomment-688493679


   Hi @orpiske great work!
   
   I was wondering which one of the contributions is predominant: better handling the remaining time or returning `null` if there are no results.
   
   Do you mind, since you already have the performance tests at hand, doing a quick comparison towards just returning `null` if the result set is empty, like: https://github.com/valdar/camel-kafka-connector/commit/2edcfc079134ec2742cac8e5fa625170f4141373


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org