[GitHub] [flink] twalthr commented on a change in pull request #11170: [FLINK-16033][table-api] Expose catalog lookup function calls in Scala's expression dsl.

[GitBox <gi...@apache.org>]

twalthr commented on a change in pull request #11170:  [FLINK-16033][table-api] Expose catalog lookup function calls in Scala's expression dsl.
URL: https://github.com/apache/flink/pull/11170#discussion_r383212202
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/expressions/resolver/ExpressionResolver.java
 ##########
 @@ -382,11 +395,13 @@ public CallExpression get(ResolvedExpression composite, ValueLiteralExpression k
 		private ExpressionResolverBuilder(
 				QueryOperation[] queryOperations,
 				TableConfig config,
+				Function<String, UnresolvedIdentifier> identifierParser,
 				TableReferenceLookup tableCatalog,
 				FunctionLookup functionLookup,
 				DataTypeFactory typeFactory) {
 			this.config = config;
 			this.queryOperations = Arrays.asList(queryOperations);
+			this.identifierParser = identifierParser;
 
 Review comment:
   How about we integrate the `identifierParser` into `FunctionLookup`. `DataTypeFactory` has also a method that takes `(String)`. I would like to reduce the number of instances that we need to pass around.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services