You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/09/22 03:34:40 UTC

[GitHub] [spark] LuciferYang commented on a diff in pull request #43008: [SPARK-44113][BUILD][INFRA][DOCS] Drop support for Scala 2.12

LuciferYang commented on code in PR #43008:
URL: https://github.com/apache/spark/pull/43008#discussion_r1333841049


##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -131,14 +132,16 @@ jettison/1.5.4//jettison-1.5.4.jar
 jetty-util-ajax/9.4.52.v20230823//jetty-util-ajax-9.4.52.v20230823.jar
 jetty-util/9.4.52.v20230823//jetty-util-9.4.52.v20230823.jar
 jline/2.14.6//jline-2.14.6.jar
+jline/3.22.0//jline-3.22.0.jar
+jna/5.13.0//jna-5.13.0.jar

Review Comment:
   Yes, I saw this dependency before, It is a cascading dependency of Scala 2.13. I think it is safe because the package name is different
   
   jline2 is `jline`
   
   <img width="467" alt="image" src="https://github.com/apache/spark/assets/1475305/ea1d77d6-c1ef-401e-a679-9433872ff712">
   
   jline3 is `org.jline`
   
   <img width="439" alt="image" src="https://github.com/apache/spark/assets/1475305/60513fca-bbbd-4192-bb21-ade59891db03">
   
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org