[GitHub] [cordova-plugin-network-information] breautek commented on pull request #114: Android - Fixes https://github.com/apache/cordova-plugin-network-information#110

[GitBox <gi...@apache.org>]

breautek commented on pull request #114:
URL: https://github.com/apache/cordova-plugin-network-information/pull/114#issuecomment-640088345


   Comments on the original still applies: https://github.com/apache/cordova-plugin-network-information/pull/111#issuecomment-640073128
   
   With the important note of:
   
   > This looks good to me. While this is fixing a bug, it is changing behaviour (which is to stop event firing on resume, if there was no change in state), which is a behaviour that some people may be dependent on. Because of this, I think we need to treat this as a breaking change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org