You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eagle.apache.org by wujinhu <gi...@git.apache.org> on 2016/11/29 10:04:06 UTC
[GitHub] incubator-eagle pull request #698: [EAGLE-814] fix alertId is null in AlertS...
GitHub user wujinhu opened a pull request:
https://github.com/apache/incubator-eagle/pull/698
[EAGLE-814] fix alertId is null in AlertStreamEvent bug
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wujinhu/incubator-eagle EAGLE-814
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/698.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #698
----
commit 3c2421adc8ae76952e9efb4be92263e8dee385c3
Author: wujinhu <wu...@126.com>
Date: 2016-11-29T10:03:15Z
fix alertId is null in AlertStreamEvent bug
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #698: [EAGLE-814] fix alertId is null in AlertStreamEv...
Posted by garrettlish <gi...@git.apache.org>.
Github user garrettlish commented on the issue:
https://github.com/apache/incubator-eagle/pull/698
+ 1
The issue is introduced by https://github.com/apache/incubator-eagle/commit/38ec7fc23d06c77b6e083ad2dfb9c61e729901e0#diff-2bb6be6fb3afdc59db75e1919ad89beaL97 which changed the alertId from AlertPublishEvent initialisation with random UUID to use AlertStreamEvent.alertId. However, AlertStreamEvent.alertId is not always initialised. The fix looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #698: [EAGLE-814] fix alertId is null in AlertS...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-eagle/pull/698
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---