You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2016/05/09 08:44:40 UTC
[GitHub] flink pull request: [FLINK-3869] Relax window fold generic paramet...
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/1973
[FLINK-3869] Relax window fold generic parameters
Before, the WindowFunction in a fold/apply could not emit a type that
was different from the accumulator type of the fold. This restriction is
unnecessary.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink window-fold-relax
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1973.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1973
----
commit 0e0d9b79b770d9708935920014314e4021e9751e
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2016-05-05T06:34:44Z
[FLINK-3869] Relax window fold generic parameters
Before, the WindowFunction in a fold/apply could not emit a type that
was different from the accumulator type of the fold. This restriction is
unnecessary.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3869] Relax window fold generic paramet...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1973#issuecomment-218780017
@StephanEwen Scala won't let me have overloaded functions. I can only fix it for the Java API because there it is non-breaking. It is, however, a severe limitation for the Scala API.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #1973: [FLINK-3869] Relax window fold generic parameters
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/1973
Kk, I added it to our "breaking changes for Flink 2.0" umbrella ticket. Closing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3869] Relax window fold generic paramet...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1973#issuecomment-218142278
This is an API breaking change.
Is there a way to overload the functions to make this non-API breaking?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3869] Relax window fold generic paramet...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1973#issuecomment-218145066
I thought it wasn't breaking because it only changes the generic parameters. Any existing user code should still work as before. Or does the generics change break binary compatibility?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #1973: [FLINK-3869] Relax window fold generic parameters
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/1973
I would say so
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #1973: [FLINK-3869] Relax window fold generic parameters
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/1973
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #1973: [FLINK-3869] Relax window fold generic parameters
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/1973
So we shouldn't fix and but keep track of it for Flink 2.0?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #1973: [FLINK-3869] Relax window fold generic parameters
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/1973
I think the API breaking changes preventer will reject this.
It is all public methods, and the signature changes (implicit parameters and context bounds are parameters in the bytecode)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---