You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/09 05:06:41 UTC
[GitHub] [dolphinscheduler] wendongdi opened a new issue, #11876: [Improvement] [dolphinscheduler-tools] upgrade process can be made directly after init process
wendongdi opened a new issue, #11876:
URL: https://github.com/apache/dolphinscheduler/issues/11876
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
i think the runner function can be optimized:
upgrade process can be made directly after init process:
```JAVA
@Override
public void run(String... args) throws Exception {
if (!dolphinSchedulerManager.schemaIsInitialized()) {
dolphinSchedulerManager.initDolphinScheduler();
logger.info("init DolphinScheduler finished");
}
dolphinSchedulerManager.upgradeDolphinScheduler();
logger.info("upgrade DolphinScheduler finished");
}
```
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wendongdi closed issue #11876: [Improvement] [dolphinscheduler-tools] upgrade process can be made directly after init process
Posted by GitBox <gi...@apache.org>.
wendongdi closed issue #11876: [Improvement] [dolphinscheduler-tools] upgrade process can be made directly after init process
URL: https://github.com/apache/dolphinscheduler/issues/11876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wendongdi commented on issue #11876: [Improvement] [dolphinscheduler-tools] upgrade process can be made directly after init process
Posted by GitBox <gi...@apache.org>.
wendongdi commented on issue #11876:
URL: https://github.com/apache/dolphinscheduler/issues/11876#issuecomment-1242668258
> Can you give an example?
In current UpgradeDolphinScheduler code：
```JAVA
@Override
public void run(String... args) throws Exception {
if (dolphinSchedulerManager.schemaIsInitialized()) {
dolphinSchedulerManager.upgradeDolphinScheduler();
logger.info("upgrade DolphinScheduler finished");
} else {
dolphinSchedulerManager.initDolphinScheduler();
logger.info("init DolphinScheduler finished");
}
}
```
it has been judged whether the schema has been initialized. If not, it will be initialized, but it will not upgrade after that. I don't think this is reasonable.
The initDolphinScheduler function only update the schema to version 3.0.0（not the latest version），so i have to run this function again to upgrade the schema.
I don't understand why not init&update to the latest version all at once？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #11876: [Improvement] [dolphinscheduler-tools] upgrade process can be made directly after init process
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #11876:
URL: https://github.com/apache/dolphinscheduler/issues/11876#issuecomment-1241783350
Can you give an example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11876: [Improvement] [dolphinscheduler-tools] upgrade process can be made directly after init process
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11876:
URL: https://github.com/apache/dolphinscheduler/issues/11876#issuecomment-1241520102
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org