You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by leifurhauks <gi...@git.apache.org> on 2016/02/02 21:05:49 UTC
[GitHub] incubator-tinkerpop pull request: TinkerFactory.createClassic -> c...
GitHub user leifurhauks opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/208
TinkerFactory.createClassic -> createModern
fixed reference to TinkerFactory.createClassic that should refer instead to TinkerFactory.createModern, which creates the version of TinkerGraph with vertex labels.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/leifurhauks/incubator-tinkerpop patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/208.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #208
----
commit 13dbfe94d2cf290496be5555faaa1519401614cd
Author: Leifur Halldor Asgeirsson <le...@gmail.com>
Date: 2016-02-02T20:04:45Z
TinkerFactory.createClassic -> createModern
fixed reference to TinkerFactory.createClassic that should refer instead to TinkerFactory.createModern, which creates the version of TinkerGraph with vertex labels.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TinkerFactory.createClassic -> c...
Posted by leifurhauks <gi...@git.apache.org>.
Github user leifurhauks commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/208#issuecomment-178816797
Ah, good point. So it's not quite equivalent to either classic or modern.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TinkerFactory.createClassic -> c...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/208#issuecomment-181906019
Short of there being some consensus to convert "classic" to "modern" in the docs, I don't think there's anything to change here. Going to close this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TinkerFactory.createClassic -> c...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/208#issuecomment-178808940
I think this was meant to be `createClassic()` - note the use of float values for the "weight" property.
@okram any recollection on why we used classic here at all? would it be better to demonstrate graph structure with modern since it includes vertex labels?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TinkerFactory.createClassic -> c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/208
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---