You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Jukka Zitting (Created) (JIRA)" <ji...@apache.org> on 2012/02/06 17:59:59 UTC
[jira] [Created] (JCR-3227) VolatileIndex not closed properly
VolatileIndex not closed properly
---------------------------------
Key: JCR-3227
URL: https://issues.apache.org/jira/browse/JCR-3227
Project: Jackrabbit Content Repository
Issue Type: Bug
Components: jackrabbit-core
Affects Versions: 2.4
Reporter: Jukka Zitting
Priority: Minor
The MultiIndex.resetVolatileIndex() method doesn't properly close the existing VolatileIndex instance before creating a new one. This can confuse the DynamicPooledExecutor reference count added in JCR-2836, leading to a background thread leak.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3227) VolatileIndex not closed properly
Posted by "Jukka Zitting (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202233#comment-13202233 ]
Jukka Zitting commented on JCR-3227:
------------------------------------
+1 looks good. The null assignment can be skipped since the next statement just overrides it.
> VolatileIndex not closed properly
> ---------------------------------
>
> Key: JCR-3227
> URL: https://issues.apache.org/jira/browse/JCR-3227
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.4
> Reporter: Jukka Zitting
> Priority: Minor
> Attachments: JCR-3227.patch
>
>
> The MultiIndex.resetVolatileIndex() method doesn't properly close the existing VolatileIndex instance before creating a new one. This can confuse the DynamicPooledExecutor reference count added in JCR-2836, leading to a background thread leak.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3227) VolatileIndex not closed properly
Posted by "Alex Parvulescu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Parvulescu updated JCR-3227:
---------------------------------
Attachment: JCR-3227.patch
yup, that is indeed a bug
the fix looks simple enough.
attached proposed patch
> VolatileIndex not closed properly
> ---------------------------------
>
> Key: JCR-3227
> URL: https://issues.apache.org/jira/browse/JCR-3227
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.4
> Reporter: Jukka Zitting
> Priority: Minor
> Attachments: JCR-3227.patch
>
>
> The MultiIndex.resetVolatileIndex() method doesn't properly close the existing VolatileIndex instance before creating a new one. This can confuse the DynamicPooledExecutor reference count added in JCR-2836, leading to a background thread leak.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3227) VolatileIndex not closed properly
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-3227:
-------------------------------
Fix Version/s: (was: 2.6)
2.5
> VolatileIndex not closed properly
> ---------------------------------
>
> Key: JCR-3227
> URL: https://issues.apache.org/jira/browse/JCR-3227
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.4
> Reporter: Jukka Zitting
> Priority: Minor
> Fix For: 2.4.1, 2.5
>
> Attachments: JCR-3227.patch
>
>
> The MultiIndex.resetVolatileIndex() method doesn't properly close the existing VolatileIndex instance before creating a new one. This can confuse the DynamicPooledExecutor reference count added in JCR-2836, leading to a background thread leak.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3227) VolatileIndex not closed properly
Posted by "Alex Parvulescu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Parvulescu updated JCR-3227:
---------------------------------
Fix Version/s: 2.6
> VolatileIndex not closed properly
> ---------------------------------
>
> Key: JCR-3227
> URL: https://issues.apache.org/jira/browse/JCR-3227
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.4
> Reporter: Jukka Zitting
> Priority: Minor
> Fix For: 2.4.1, 2.6
>
> Attachments: JCR-3227.patch
>
>
> The MultiIndex.resetVolatileIndex() method doesn't properly close the existing VolatileIndex instance before creating a new one. This can confuse the DynamicPooledExecutor reference count added in JCR-2836, leading to a background thread leak.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3227) VolatileIndex not closed properly
Posted by "Alex Parvulescu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236581#comment-13236581 ]
Alex Parvulescu commented on JCR-3227:
--------------------------------------
ported to 2.4 in rev 1304334.
> VolatileIndex not closed properly
> ---------------------------------
>
> Key: JCR-3227
> URL: https://issues.apache.org/jira/browse/JCR-3227
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.4
> Reporter: Jukka Zitting
> Priority: Minor
> Fix For: 2.4.1, 2.6
>
> Attachments: JCR-3227.patch
>
>
> The MultiIndex.resetVolatileIndex() method doesn't properly close the existing VolatileIndex instance before creating a new one. This can confuse the DynamicPooledExecutor reference count added in JCR-2836, leading to a background thread leak.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JCR-3227) VolatileIndex not closed properly
Posted by "Alex Parvulescu (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Parvulescu resolved JCR-3227.
----------------------------------
Resolution: Fixed
Fix Version/s: 2.4.1
> The null assignment can be skipped since the next statement just overrides it.
agreed
fixed in rev: 1241461
> VolatileIndex not closed properly
> ---------------------------------
>
> Key: JCR-3227
> URL: https://issues.apache.org/jira/browse/JCR-3227
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.4
> Reporter: Jukka Zitting
> Priority: Minor
> Fix For: 2.4.1
>
> Attachments: JCR-3227.patch
>
>
> The MultiIndex.resetVolatileIndex() method doesn't properly close the existing VolatileIndex instance before creating a new one. This can confuse the DynamicPooledExecutor reference count added in JCR-2836, leading to a background thread leak.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira