[GitHub] [accumulo] keith-turner commented on a change in pull request #1709: DO NOT MERGE - concept for discussion - code would not work as is

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #1709:
URL: https://github.com/apache/accumulo/pull/1709#discussion_r493114355



##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
##########
@@ -449,7 +584,33 @@ private void manageMemory() {
           mma = memoryManager.getMemoryManagementActions(tabletStates);
 
         } catch (Throwable t) {
+
           log.error("Memory manager failed {}", t.getMessage(), t);
+
+          // treat error as unrecoverable - get zookeeper and delete server lock to kill instance.

Review comment:
       If a tablet server needs to kill itself, it would probably be better to halt rather than deleting the lock.  If things are not going well inside the process, deleting the lock may not kill the process.  Halting probably has a better chance.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org