You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/23 23:16:22 UTC

[GitHub] [tvm] tkonolige opened a new pull request, #11860: [PROFILING] Catch any errors while setting locale for printing

tkonolige opened a new pull request, #11860:
URL: https://github.com/apache/tvm/pull/11860

   Change profiling::Report printing to catch any errors when setting the locale (used to add separators to large numbers). This avoids issues around misconfigured locale.
   
   @junrushao1994 @yogurfrul 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] yogurfrul commented on pull request #11860: [PROFILING] Catch any errors while setting locale for printing

Posted by GitBox <gi...@apache.org>.
yogurfrul commented on PR #11860:
URL: https://github.com/apache/tvm/pull/11860#issuecomment-1165128887

   
   ```
   /**
        *  @brief  Default constructor.
        *
        *  Constructs a copy of the global locale.  If no locale has been
        *  explicitly set, this is the C locale.
       */
       locale() throw();
   ```
   
   it works fine in my case by just removing empty string ""
   and I can not figure out any difference of profiling print detail
   your new code with try catch works too~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tkonolige commented on pull request #11860: [PROFILING] Catch any errors while setting locale for printing

Posted by GitBox <gi...@apache.org>.
tkonolige commented on PR #11860:
URL: https://github.com/apache/tvm/pull/11860#issuecomment-1165764200

   @yogurfrul We do not want the "C" locale, we want the user's locale as it may specify how to print thousands separators. In your case, your locale probably does not indicate to print thousands separators so you see no difference. In other cases, like with `en_US.UTF-8`, you will get thousands separators on large numbers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 merged pull request #11860: [PROFILING] Catch any errors while setting locale for printing

Posted by GitBox <gi...@apache.org>.
junrushao1994 merged PR #11860:
URL: https://github.com/apache/tvm/pull/11860


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #11860: [PROFILING] Catch any errors while setting locale for printing

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on PR #11860:
URL: https://github.com/apache/tvm/pull/11860#issuecomment-1165936013

   Well, I didn't see much difference except for a comma, but given it works for @yogurfrul's setting, i'm merging it in :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tkonolige commented on pull request #11860: [PROFILING] Catch any errors while setting locale for printing

Posted by GitBox <gi...@apache.org>.
tkonolige commented on PR #11860:
URL: https://github.com/apache/tvm/pull/11860#issuecomment-1165952233

   The point is the comma :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org