You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "linrrzqqq (via GitHub)" <gi...@apache.org> on 2025/11/03 10:27:48 UTC
[PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
linrrzqqq opened a new pull request, #57643:
URL: https://github.com/apache/doris/pull/57643
### What problem does this PR solve?
Before:
```text
mysql> SELECT REGEXP('Apache/Doris', '([a-zA-Z_+-]+(?:\/[a-zA-Z_0-9+-]+)*)(?=s|$)') AS res;
ERROR 1105 (HY000): errCode = 2, detailMessage = (127.0.0.1)[INTERNAL_ERROR]Invalid regex expression: ([a-zA-Z_+-]+(?:/[a-zA-Z_0-9+-]+)*)(?=s|$)
mysql> SELECT REGEXP_EXTRACT_ALL('ID:AA-1,ID:BB-2,ID:CC-3', '(?<=ID:)([A-Z]{2}-\\d)') AS res;
ERROR 1105 (HY000): errCode = 2, detailMessage = (127.0.0.1)[INVALID_ARGUMENT]Could not compile regexp pattern: (?<=ID:)([A-Z]{2}-\d)
Error: invalid perl operator: (?<
mysql> SELECT REGEXP_EXTRACT_OR_NULL('Apache/Doris', '([a-zA-Z_+-]+(?:\/[a-zA-Z_0-9+-]+)*)(?=s|$)', 1) AS res;
ERROR 1105 (HY000): errCode = 2, detailMessage = (127.0.0.1)[INVALID_ARGUMENT]Could not compile regexp pattern: ([a-zA-Z_+-]+(?:/[a-zA-Z_0-9+-]+)*)(?=s|$)
Error: invalid perl operator: (?=
```
After
```text
mysql> SELECT REGEXP('Apache/Doris', '([a-zA-Z_+-]+(?:\/[a-zA-Z_0-9+-]+)*)(?=s|$)') AS res;
+------+
| res |
+------+
| 1 |
+------+
mysql> SELECT REGEXP_EXTRACT_ALL('ID:AA-1,ID:BB-2,ID:CC-3', '(?<=ID:)([A-Z]{2}-\\d)') AS res;
+------------------------+
| res |
+------------------------+
| ['AA-1','BB-2','CC-3'] |
+------------------------+
mysql> SELECT REGEXP_EXTRACT_OR_NULL('Apache/Doris', '([a-zA-Z_+-]+(?:\/[a-zA-Z_0-9+-]+)*)(?=s|$)', 1) AS res;
+--------------+
| res |
+--------------+
| Apache/Doris |
+--------------+
```
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [x] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb merged PR #57643:
URL: https://github.com/apache/doris/pull/57643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3485462047
<details>
<summary>ClickBench: <b>Total hot run time: 27.41 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5bef965400e86dc1e7bd34c9eb147fa0d53ff38d, data reload: false
query1 0.06 0.05 0.05
query2 0.10 0.05 0.05
query3 0.25 0.09 0.08
query4 1.61 0.12 0.12
query5 0.27 0.25 0.26
query6 1.14 0.65 0.63
query7 0.03 0.02 0.03
query8 0.05 0.04 0.04
query9 0.59 0.53 0.52
query10 0.58 0.58 0.58
query11 0.16 0.12 0.11
query12 0.15 0.12 0.12
query13 0.62 0.60 0.59
query14 1.00 1.00 0.99
query15 0.86 0.83 0.83
query16 0.38 0.39 0.39
query17 1.07 1.03 1.06
query18 0.21 0.21 0.20
query19 1.94 1.74 1.81
query20 0.01 0.02 0.01
query21 15.43 0.23 0.14
query22 4.81 0.07 0.05
query23 15.66 0.25 0.10
query24 2.32 0.94 0.38
query25 0.07 0.06 0.05
query26 0.14 0.13 0.14
query27 0.06 0.06 0.05
query28 5.04 1.15 0.92
query29 12.55 3.95 3.24
query30 0.29 0.14 0.11
query31 2.82 0.60 0.38
query32 3.24 0.55 0.47
query33 3.13 3.13 3.05
query34 15.83 5.17 4.59
query35 4.53 4.57 4.60
query36 0.69 0.50 0.49
query37 0.10 0.06 0.06
query38 0.07 0.04 0.04
query39 0.04 0.02 0.03
query40 0.17 0.14 0.13
query41 0.08 0.04 0.03
query42 0.04 0.03 0.03
query43 0.05 0.03 0.04
Total cold run time: 98.24 s
Total hot run time: 27.41 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3485002136
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/5bef965400e86dc1e7bd34c9eb147fa0d53ff38d_5bef965400e86dc1e7bd34c9eb147fa0d53ff38d_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/5bef965400e86dc1e7bd34c9eb147fa0d53ff38d_5bef965400e86dc1e7bd34c9eb147fa0d53ff38d_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 80.71% (1674/2074) |
| Line Coverage | 67.03% (29545/44080) |
| Region Coverage | 67.58% (14700/21752) |
| Branch Coverage | 57.82% (7817/13520) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #57643:
URL: https://github.com/apache/doris/pull/57643#discussion_r2493192892
##########
be/src/vec/functions/function_regexp.cpp:
##########
@@ -51,6 +52,136 @@
namespace doris::vectorized {
#include "common/compile_check_begin.h"
+
+// Helper structure to hold either RE2 or Boost.Regex
+struct RegexpExtractEngine {
+ std::unique_ptr<re2::RE2> re2_regex;
+ std::unique_ptr<boost::regex> boost_regex;
+
+ bool is_boost() const { return boost_regex != nullptr; }
+ bool is_re2() const { return re2_regex != nullptr; }
+
+ // Try to compile with RE2 first, fallback to Boost.Regex if RE2 fails
+ static bool compile(const StringRef& pattern, std::string* error_str,
+ RegexpExtractEngine& engine, bool enable_extended_regex) {
+ engine.re2_regex = std::make_unique<re2::RE2>(re2::StringPiece(pattern.data, pattern.size));
+ if (engine.re2_regex->ok()) {
+ return true;
+ } else if (!enable_extended_regex) {
+ *error_str =
Review Comment:
maybe we can add some hit msg to tell user to set enable_extended_regex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3479862414
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #57643:
URL: https://github.com/apache/doris/pull/57643#discussion_r2493198082
##########
be/src/runtime/runtime_state.h:
##########
@@ -750,6 +751,10 @@ class RuntimeState {
cctz::time_zone _timezone_obj;
std::string _lc_time_names;
+ // Support extended regex
+ // like look-around zero-width assertions(`?=`, `?!`, `?<=`, `?<!`)
+ bool _enable_extended_regex;
Review Comment:
I think RuntimeState will storage a query options object, can we set it instead of a single boolean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #57643:
URL: https://github.com/apache/doris/pull/57643#discussion_r2493194883
##########
be/src/vec/functions/like.cpp:
##########
@@ -1009,7 +1017,22 @@ Status FunctionRegexpLike::open(FunctionContext* context,
opts.set_dot_nl(true);
state->search_state.regex = std::make_unique<RE2>(pattern_str, opts);
if (!state->search_state.regex->ok()) {
- return Status::InternalError("Invalid regex expression: {}", pattern_str);
+ if (!context->state()->enable_extended_regex()) {
+ return Status::InternalError("Invalid regex expression: {}. Error: {}",
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3490596920
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3492749657
# FE Regression Coverage Report
Increment line coverage ` 100.00% (2/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57643_d0cfd1ac55631ebca64e2621e2fb241aa1f15866_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57643_d0cfd1ac55631ebca64e2621e2fb241aa1f15866_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3484847350
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3488820652
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3492075005
run nonConcurrent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3485429794
<details>
<summary>TPC-DS: <b>Total hot run time: 190724 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5bef965400e86dc1e7bd34c9eb147fa0d53ff38d, data reload: false
query1 1085 404 387 387
query2 6569 1729 1691 1691
query3 6761 223 225 223
query4 26276 23467 23460 23460
query5 4432 638 494 494
query6 340 230 219 219
query7 4646 496 295 295
query8 307 263 274 263
query9 8754 2613 2614 2613
query10 491 348 315 315
query11 15349 15473 14973 14973
query12 192 125 114 114
query13 1697 583 437 437
query14 11342 9348 9369 9348
query15 201 194 176 176
query16 7731 727 607 607
query17 1306 896 743 743
query18 2207 452 352 352
query19 239 230 199 199
query20 144 130 125 125
query21 224 141 125 125
query22 4762 4625 4505 4505
query23 34858 34000 33938 33938
query24 8655 2499 2503 2499
query25 630 581 486 486
query26 1270 289 160 160
query27 2732 523 367 367
query28 4348 2210 2232 2210
query29 838 640 530 530
query30 304 269 214 214
query31 941 845 770 770
query32 77 78 81 78
query33 602 387 319 319
query34 815 902 548 548
query35 859 896 756 756
query36 1001 1048 943 943
query37 132 116 86 86
query38 3543 3608 3470 3470
query39 1442 1398 1405 1398
query40 235 127 118 118
query41 59 59 56 56
query42 116 113 113 113
query43 487 506 473 473
query44 1208 732 720 720
query45 178 175 171 171
query46 891 994 634 634
query47 1743 1828 1754 1754
query48 380 414 326 326
query49 779 515 405 405
query50 639 683 417 417
query51 3846 3908 4045 3908
query52 110 103 96 96
query53 235 265 195 195
query54 303 300 272 272
query55 83 88 85 85
query56 332 314 322 314
query57 1169 1211 1128 1128
query58 283 284 273 273
query59 2581 2673 2540 2540
query60 353 335 312 312
query61 161 151 158 151
query62 783 725 656 656
query63 225 196 195 195
query64 4480 1158 847 847
query65 4023 3994 3996 3994
query66 1080 429 327 327
query67 15464 15222 14894 14894
query68 8494 919 597 597
query69 491 324 287 287
query70 1348 1287 1290 1287
query71 467 334 308 308
query72 5905 5261 5005 5005
query73 654 578 360 360
query74 8920 9191 8938 8938
query75 3566 3325 2835 2835
query76 3453 1165 739 739
query77 729 415 319 319
query78 9538 9678 9055 9055
query79 2715 801 583 583
query80 697 568 557 557
query81 525 261 230 230
query82 408 152 134 134
query83 268 257 249 249
query84 252 111 92 92
query85 978 488 432 432
query86 376 304 292 292
query87 3727 3707 3700 3700
query88 4049 2245 2243 2243
query89 383 330 290 290
query90 1953 212 232 212
query91 175 168 136 136
query92 85 70 65 65
query93 2409 993 652 652
query94 690 435 334 334
query95 397 325 314 314
query96 479 569 283 283
query97 2927 2965 2872 2872
query98 237 222 212 212
query99 1345 1414 1302 1302
Total cold run time: 278968 ms
Total hot run time: 190724 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #57643:
URL: https://github.com/apache/doris/pull/57643#discussion_r2493198865
##########
be/src/vec/functions/function_regexp.cpp:
##########
@@ -51,6 +52,136 @@
namespace doris::vectorized {
#include "common/compile_check_begin.h"
+
+// Helper structure to hold either RE2 or Boost.Regex
+struct RegexpExtractEngine {
+ std::unique_ptr<re2::RE2> re2_regex;
+ std::unique_ptr<boost::regex> boost_regex;
+
+ bool is_boost() const { return boost_regex != nullptr; }
+ bool is_re2() const { return re2_regex != nullptr; }
+
+ // Try to compile with RE2 first, fallback to Boost.Regex if RE2 fails
+ static bool compile(const StringRef& pattern, std::string* error_str,
+ RegexpExtractEngine& engine, bool enable_extended_regex) {
+ engine.re2_regex = std::make_unique<re2::RE2>(re2::StringPiece(pattern.data, pattern.size));
+ if (engine.re2_regex->ok()) {
+ return true;
+ } else if (!enable_extended_regex) {
+ *error_str =
+ fmt::format("Invalid regex pattern: {}. Error: {}",
+ std::string(pattern.data, pattern.size), engine.re2_regex->error());
+ return false;
+ }
+
+ // RE2 failed, try Boost.Regex for advanced features like zero-width assertions
+ engine.re2_regex.reset();
+ try {
+ boost::regex::flag_type flags = boost::regex::normal;
+ engine.boost_regex = std::make_unique<boost::regex>(pattern.data,
+ pattern.data + pattern.size, flags);
+ return true;
+ } catch (const boost::regex_error& e) {
+ if (error_str) {
+ *error_str = fmt::format("Invalid regex pattern: {}. Error: {}",
+ std::string(pattern.data, pattern.size), e.what());
+ }
+ return false;
+ }
+ }
+
+ // Get number of capturing groups
+ int number_of_capturing_groups() const {
+ if (is_re2()) {
+ return re2_regex->NumberOfCapturingGroups();
+ } else if (is_boost()) {
+ return static_cast<int>(boost_regex->mark_count());
+ }
+ return 0;
+ }
+
+ // Match function for extraction
+ bool match_and_extract(const char* data, size_t size, int index, std::string& result) const {
+ if (is_re2()) {
+ int max_matches = 1 + re2_regex->NumberOfCapturingGroups();
+ if (index >= max_matches) {
+ return false;
+ }
+ std::vector<re2::StringPiece> matches(max_matches);
+ bool success = re2_regex->Match(re2::StringPiece(data, size), 0, size,
+ re2::RE2::UNANCHORED, matches.data(), max_matches);
+ if (success && index < matches.size()) {
+ const re2::StringPiece& match = matches[index];
+ result.assign(match.data(), match.size());
+ return true;
+ }
+ return false;
+ } else if (is_boost()) {
+ boost::cmatch matches;
+ bool success = boost::regex_search(data, data + size, matches, *boost_regex);
+ if (success && index < matches.size()) {
+ result = matches[index].str();
+ return true;
+ }
+ return false;
+ }
+ return false;
+ }
Review Comment:
Potential type safety issue: `index` parameter is `int`, but it's compared with `matches.size()` which returns `size_t` (unsigned). At line 122, if `index` is negative, the comparison `index < matches.size()` will treat it as a large positive value due to integer conversion, potentially causing out-of-bounds access. Consider adding a check `if (index < 0) return false;` before the comparisons.
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -3094,6 +3096,11 @@ public boolean isEnableESParallelScroll() {
)
public int defaultVariantMaxSparseColumnStatisticsSize = 10000;
+ @VariableMgr.VarAttr(name = ENABLE_EXTENDED_REGEX, needForward = true, affectQueryResult = true,
+ description = {"是否启用扩展的正则表达式, 支持如 look-round 类的零宽断言",
+ "Enable extended regular expressions, support look-round zero-width assertions"})
Review Comment:
Typo in the Chinese description: 'look-round' should be 'look-around' to match the English terminology used elsewhere in the codebase.
```suggestion
description = {"是否启用扩展的正则表达式, 支持如 look-around 类的零宽断言",
"Enable extended regular expressions, support look-around zero-width assertions"})
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3479841285
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3480434948
# BE Regression && UT Coverage Report
Increment line coverage `82.39% (117/142)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57643_d5abb79b2d48e090c4d329d1c9915970b44ee6a4_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57643_d5abb79b2d48e090c4d329d1c9915970b44ee6a4_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.49% (24075/33674) |
| Line Coverage | 57.93% (250648/432693) |
| Region Coverage | 53.02% (208156/392563) |
| Branch Coverage | 54.72% (89375/163343) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3492073108
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3485787846
# BE UT Coverage Report
Increment line coverage `46.84% (74/158)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/5bef965400e86dc1e7bd34c9eb147fa0d53ff38d_5bef965400e86dc1e7bd34c9eb147fa0d53ff38d/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/5bef965400e86dc1e7bd34c9eb147fa0d53ff38d_5bef965400e86dc1e7bd34c9eb147fa0d53ff38d/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.74% (18089/34301) |
| Line Coverage | 38.05% (164512/432399) |
| Region Coverage | 32.35% (125320/387380) |
| Branch Coverage | 33.80% (54907/162458) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3492682556
# BE Regression && UT Coverage Report
Increment line coverage `84.38% (135/160)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57643_d0cfd1ac55631ebca64e2621e2fb241aa1f15866_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57643_d0cfd1ac55631ebca64e2621e2fb241aa1f15866_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.58% (24263/33895) |
| Line Coverage | 58.12% (252662/434748) |
| Region Coverage | 53.55% (211066/394151) |
| Branch Coverage | 54.97% (90332/164331) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3486007338
# BE Regression && UT Coverage Report
Increment line coverage `84.18% (133/158)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57643_5bef965400e86dc1e7bd34c9eb147fa0d53ff38d_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57643_5bef965400e86dc1e7bd34c9eb147fa0d53ff38d_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.46% (24097/33720) |
| Line Coverage | 57.89% (250729/433146) |
| Region Coverage | 53.02% (208356/392977) |
| Branch Coverage | 54.72% (89512/163567) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3490609077
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/d0cfd1ac55631ebca64e2621e2fb241aa1f15866_d0cfd1ac55631ebca64e2621e2fb241aa1f15866_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/d0cfd1ac55631ebca64e2621e2fb241aa1f15866_d0cfd1ac55631ebca64e2621e2fb241aa1f15866_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 80.76% (1675/2074) |
| Line Coverage | 66.99% (29573/44143) |
| Region Coverage | 67.63% (14728/21777) |
| Branch Coverage | 57.86% (7832/13536) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #57643:
URL: https://github.com/apache/doris/pull/57643#discussion_r2493200960
##########
gensrc/thrift/PaloInternalService.thrift:
##########
@@ -492,6 +492,9 @@ struct TQueryGlobals {
// Locale name used for month/day names formatting, e.g. en_US
6: optional string lc_time_names
+
+ // Support extended regex, like look-around zero-width assertions(`?=`, `?!`, `?<=`, `?<!`)
+ 7: optional bool enable_extended_regex
Review Comment:
Why set it into TQueryGlobals not TQueryOptions?
What is the difference between the two
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3490597121
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3490928641
<details>
<summary>TPC-DS: <b>Total hot run time: 189920 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d0cfd1ac55631ebca64e2621e2fb241aa1f15866, data reload: false
query1 1066 419 393 393
query2 6573 1685 1673 1673
query3 6761 226 225 225
query4 27522 23781 23474 23474
query5 4404 619 474 474
query6 341 258 244 244
query7 4649 515 302 302
query8 317 271 253 253
query9 8714 2573 2578 2573
query10 503 353 294 294
query11 15897 15105 14855 14855
query12 189 125 113 113
query13 1692 579 455 455
query14 11037 9309 9365 9309
query15 205 193 186 186
query16 7744 667 499 499
query17 1257 786 646 646
query18 2095 478 369 369
query19 231 232 193 193
query20 138 132 130 130
query21 236 148 126 126
query22 4812 4748 4612 4612
query23 35092 33856 33670 33670
query24 9299 2520 2528 2520
query25 617 547 474 474
query26 1319 286 161 161
query27 3642 531 359 359
query28 4424 2219 2178 2178
query29 841 663 533 533
query30 388 236 200 200
query31 951 903 773 773
query32 82 72 68 68
query33 605 403 362 362
query34 818 873 543 543
query35 821 876 795 795
query36 982 1021 897 897
query37 135 117 88 88
query38 3692 3757 3611 3611
query39 1485 1438 1426 1426
query40 216 120 114 114
query41 59 58 56 56
query42 119 113 108 108
query43 504 477 489 477
query44 1211 731 722 722
query45 185 176 173 173
query46 884 981 628 628
query47 1748 1799 1724 1724
query48 388 452 317 317
query49 773 517 415 415
query50 630 686 416 416
query51 3865 3971 3818 3818
query52 114 104 99 99
query53 232 272 196 196
query54 303 284 275 275
query55 82 92 82 82
query56 358 309 304 304
query57 1189 1211 1119 1119
query58 288 265 273 265
query59 2565 2637 2578 2578
query60 352 339 309 309
query61 157 153 148 148
query62 797 727 692 692
query63 232 201 196 196
query64 4468 1187 838 838
query65 4032 3940 3950 3940
query66 1079 421 323 323
query67 15250 15009 15016 15009
query68 7768 855 595 595
query69 468 315 288 288
query70 1342 1357 1317 1317
query71 426 338 323 323
query72 5981 4969 4770 4770
query73 597 585 362 362
query74 8951 9269 8993 8993
query75 3313 3388 2858 2858
query76 3116 1152 738 738
query77 592 395 302 302
query78 9496 9734 8937 8937
query79 1456 833 590 590
query80 649 559 490 490
query81 516 268 227 227
query82 221 151 127 127
query83 258 255 246 246
query84 268 120 100 100
query85 881 473 429 429
query86 378 328 304 304
query87 3676 3725 3620 3620
query88 2866 2250 2240 2240
query89 371 323 297 297
query90 2035 215 213 213
query91 163 167 137 137
query92 77 66 64 64
query93 1382 988 646 646
query94 684 454 334 334
query95 398 311 309 309
query96 484 565 279 279
query97 2909 2964 2880 2880
query98 233 218 214 214
query99 1328 1399 1294 1294
Total cold run time: 276939 ms
Total hot run time: 189920 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3480090812
# BE UT Coverage Report
Increment line coverage `49.30% (70/142)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/d5abb79b2d48e090c4d329d1c9915970b44ee6a4_d5abb79b2d48e090c4d329d1c9915970b44ee6a4/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/d5abb79b2d48e090c4d329d1c9915970b44ee6a4_d5abb79b2d48e090c4d329d1c9915970b44ee6a4/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.70% (18053/34255) |
| Line Coverage | 37.99% (164096/431948) |
| Region Coverage | 32.31% (125029/386967) |
| Branch Coverage | 33.73% (54729/162234) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3486063198
# FE Regression Coverage Report
Increment line coverage ` 100.00% (3/3)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57643_5bef965400e86dc1e7bd34c9eb147fa0d53ff38d_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57643_5bef965400e86dc1e7bd34c9eb147fa0d53ff38d_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3490465930
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3490952140
<details>
<summary>ClickBench: <b>Total hot run time: 28.22 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d0cfd1ac55631ebca64e2621e2fb241aa1f15866, data reload: false
query1 0.05 0.05 0.05
query2 0.13 0.07 0.07
query3 0.31 0.07 0.08
query4 1.61 0.09 0.08
query5 0.27 0.26 0.25
query6 1.16 0.65 0.64
query7 0.02 0.02 0.02
query8 0.07 0.06 0.05
query9 0.65 0.54 0.53
query10 0.59 0.59 0.58
query11 0.27 0.13 0.14
query12 0.26 0.15 0.14
query13 0.63 0.63 0.62
query14 1.02 1.02 1.04
query15 0.94 0.86 0.87
query16 0.39 0.39 0.41
query17 1.02 1.04 1.05
query18 0.24 0.22 0.22
query19 2.02 1.82 1.81
query20 0.02 0.01 0.01
query21 15.40 0.29 0.23
query22 4.98 0.10 0.09
query23 15.37 0.39 0.23
query24 2.85 0.49 0.31
query25 0.10 0.10 0.09
query26 0.18 0.17 0.19
query27 0.09 0.10 0.09
query28 3.63 1.25 1.06
query29 12.58 3.99 3.33
query30 0.34 0.12 0.10
query31 2.81 0.63 0.44
query32 3.25 0.61 0.51
query33 3.03 3.05 3.08
query34 16.67 5.29 4.47
query35 4.52 4.59 4.45
query36 0.65 0.51 0.51
query37 0.23 0.09 0.09
query38 0.19 0.06 0.05
query39 0.06 0.04 0.04
query40 0.20 0.19 0.18
query41 0.11 0.06 0.06
query42 0.06 0.04 0.05
query43 0.06 0.05 0.05
Total cold run time: 99.03 s
Total hot run time: 28.22 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](regexp) Support zero-width assertions in some regexp functions [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57643:
URL: https://github.com/apache/doris/pull/57643#issuecomment-3491410300
# BE UT Coverage Report
Increment line coverage `46.25% (74/160)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/d0cfd1ac55631ebca64e2621e2fb241aa1f15866_d0cfd1ac55631ebca64e2621e2fb241aa1f15866/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/d0cfd1ac55631ebca64e2621e2fb241aa1f15866_d0cfd1ac55631ebca64e2621e2fb241aa1f15866/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.79% (18201/34476) |
| Line Coverage | 38.24% (165946/434003) |
| Region Coverage | 33.25% (129196/388555) |
| Branch Coverage | 34.02% (55533/163222) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org