You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dabla (via GitHub)" <gi...@apache.org> on 2025/09/24 11:25:54 UTC
[PR] Allow a list of SQL statements in GenericTransfer [airflow]
dabla opened a new pull request, #56041:
URL: https://github.com/apache/airflow/pull/56041
…t like the SQLExecuteQueryOperator to avoid the need to use partial/expand which is way more expensive than looping over the SQL-statements within the operator
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Allow a list of SQL statements to be passed to the GenericTransfer just like the SQLExecuteQueryOperator to avoid the need to use partial/expand which is way more expensive than looping over the SQL-statements within the operator
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow a list of SQL statements in GenericTransfer [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #56041:
URL: https://github.com/apache/airflow/pull/56041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow a list of SQL statements in GenericTransfer [airflow]
Posted by "dabla (via GitHub)" <gi...@apache.org>.
dabla commented on code in PR #56041:
URL: https://github.com/apache/airflow/pull/56041#discussion_r2468932491
##########
providers/common/sql/tests/unit/common/sql/operators/test_generic_transfer.py:
##########
@@ -273,7 +273,7 @@ def test_non_paginated_read(self):
task_id="transfer_table",
source_conn_id="my_source_conn_id",
destination_conn_id="my_destination_conn_id",
- sql="SELECT * FROM HR.EMPLOYEES",
+ sql=["SELECT * FROM HR.EMPLOYEES"],
Review Comment:
So I don't know it it actually makes sense to test both cases, as it's delegated to the hook anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow a list of SQL statements in GenericTransfer [airflow]
Posted by "dabla (via GitHub)" <gi...@apache.org>.
dabla commented on code in PR #56041:
URL: https://github.com/apache/airflow/pull/56041#discussion_r2450504664
##########
providers/common/sql/tests/unit/common/sql/operators/test_generic_transfer.py:
##########
@@ -273,7 +273,7 @@ def test_non_paginated_read(self):
task_id="transfer_table",
source_conn_id="my_source_conn_id",
destination_conn_id="my_destination_conn_id",
- sql="SELECT * FROM HR.EMPLOYEES",
+ sql=["SELECT * FROM HR.EMPLOYEES"],
Review Comment:
Actually, there is no separate test needed for this, as this single sql statement or multiple sql statement is handled by the get_records method of the DbApiHook. Also, I've passed a list of sql to the non paginated read and and a single sql to the paginated one, so both cases are covered anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow a list of SQL statements in GenericTransfer [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #56041:
URL: https://github.com/apache/airflow/pull/56041#discussion_r2468276356
##########
providers/common/sql/src/airflow/providers/common/sql/operators/generic_transfer.py:
##########
@@ -156,13 +156,19 @@ def execute(self, context: Context):
method_name=self.execute_complete.__name__,
)
else:
- self.log.info("Extracting data from %s", self.source_conn_id)
- self.log.info("Executing: \n %s", self.sql)
+ if isinstance(self.sql, str):
+ self.sql = [self.sql]
- results = self.source_hook.get_records(self.sql)
+ for sql in self.sql:
+ self.log.info("Extracting data from %s", self.source_conn_id)
+ self.log.info("Executing: \n %s", sql)
Review Comment:
```suggestion
self.log.info("Extracting data from %s", self.source_conn_id)
for sql in self.sql:
self.log.info("Executing: \n %s", sql)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow a list of SQL statements in GenericTransfer [airflow]
Posted by "dabla (via GitHub)" <gi...@apache.org>.
dabla commented on code in PR #56041:
URL: https://github.com/apache/airflow/pull/56041#discussion_r2469112528
##########
providers/common/sql/tests/unit/common/sql/operators/test_generic_transfer.py:
##########
@@ -273,7 +273,7 @@ def test_non_paginated_read(self):
task_id="transfer_table",
source_conn_id="my_source_conn_id",
destination_conn_id="my_destination_conn_id",
- sql="SELECT * FROM HR.EMPLOYEES",
+ sql=["SELECT * FROM HR.EMPLOYEES"],
Review Comment:
Actually I was wrong, the looping is indeed done in operator, even though it could be done through hooks, I prefer to keep it this way so we don't consume too much memory. Will add a dedicated test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow a list of SQL statements in GenericTransfer [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #56041:
URL: https://github.com/apache/airflow/pull/56041#discussion_r2468282159
##########
providers/common/sql/tests/unit/common/sql/operators/test_generic_transfer.py:
##########
@@ -273,7 +273,7 @@ def test_non_paginated_read(self):
task_id="transfer_table",
source_conn_id="my_source_conn_id",
destination_conn_id="my_destination_conn_id",
- sql="SELECT * FROM HR.EMPLOYEES",
+ sql=["SELECT * FROM HR.EMPLOYEES"],
Review Comment:
If we are to change this, I would want the test to cover both list[str] and str. If it’s going to test only one of them, I would just keep it unmodified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow a list of SQL statements in GenericTransfer [airflow]
Posted by "dabla (via GitHub)" <gi...@apache.org>.
dabla commented on code in PR #56041:
URL: https://github.com/apache/airflow/pull/56041#discussion_r2468929154
##########
providers/common/sql/tests/unit/common/sql/operators/test_generic_transfer.py:
##########
@@ -273,7 +273,7 @@ def test_non_paginated_read(self):
task_id="transfer_table",
source_conn_id="my_source_conn_id",
destination_conn_id="my_destination_conn_id",
- sql="SELECT * FROM HR.EMPLOYEES",
+ sql=["SELECT * FROM HR.EMPLOYEES"],
Review Comment:
Well actually it doesn't matter as the list or str for sql parameter is handled by the hook anyway, not the operator, so it will put it back as it was.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow a list of SQL statements in GenericTransfer [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #56041:
URL: https://github.com/apache/airflow/pull/56041#discussion_r2427266705
##########
providers/common/sql/tests/unit/common/sql/operators/test_generic_transfer.py:
##########
@@ -273,7 +273,7 @@ def test_non_paginated_read(self):
task_id="transfer_table",
source_conn_id="my_source_conn_id",
destination_conn_id="my_destination_conn_id",
- sql="SELECT * FROM HR.EMPLOYEES",
+ sql=["SELECT * FROM HR.EMPLOYEES"],
Review Comment:
Should we have test for both - list and string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org