[GitHub] [incubator-superset] betodealmeida opened a new pull request #8268: Fix no data in Presto

[GitBox <gi...@apache.org>]

betodealmeida opened a new pull request #8268: Fix no data in Presto
URL: https://github.com/apache/incubator-superset/pull/8268
 
 
   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   Presto queries that return no data are raising the exception "too many indices for array". This happens because the Numpy array that wraps the data has shape `(0,)`, and when we create the Pandas time series for the dataframe we try to access each column using index `[:,i]`.
   
   I fixed it by reshaping the array to 2D, even if empty. Query now succeeds with "The query returned no data".
   
   <!-- ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF -->
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   I tested the failing query, and also added a unit test. I also added a unit test for https://github.com/apache/incubator-superset/pull/8253.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   @khtruong 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org