You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Simone Tripodi <si...@apache.org> on 2011/07/24 09:15:40 UTC
BCEL/JCS code repackaging (Was Re: svn commit: r1150277 - /commons/proper/jcs/trunk/src/java/org/apache/jcs/auxiliary/disk/jdbc/JDBCDiskCache.java)
Hi David!!!
this mail just to suggest you moving the JCS package from
'org.apache.jcs' to 'org.apache.commons.jcs'
same refactoring has to be applied to BCEL, from 'org.apache.bcel' to
'org.apache.commons.bcel'
HTH, have a nice day!
Simo
http://people.apache.org/~simonetripodi/
http://www.99soft.org/
On Sun, Jul 24, 2011 at 5:57 AM, <db...@apache.org> wrote:
> Author: dbrosius
> Date: Sun Jul 24 03:57:18 2011
> New Revision: 1150277
>
> URL: http://svn.apache.org/viewvc?rev=1150277&view=rev
> Log:
> remove typo of duplicate closing of jdbc statement
>
> Modified:
> commons/proper/jcs/trunk/src/java/org/apache/jcs/auxiliary/disk/jdbc/JDBCDiskCache.java
>
> Modified: commons/proper/jcs/trunk/src/java/org/apache/jcs/auxiliary/disk/jdbc/JDBCDiskCache.java
> URL: http://svn.apache.org/viewvc/commons/proper/jcs/trunk/src/java/org/apache/jcs/auxiliary/disk/jdbc/JDBCDiskCache.java?rev=1150277&r1=1150276&r2=1150277&view=diff
> ==============================================================================
> --- commons/proper/jcs/trunk/src/java/org/apache/jcs/auxiliary/disk/jdbc/JDBCDiskCache.java (original)
> +++ commons/proper/jcs/trunk/src/java/org/apache/jcs/auxiliary/disk/jdbc/JDBCDiskCache.java Sun Jul 24 03:57:18 2011
> @@ -476,7 +476,6 @@ public class JDBCDiskCache
> {
> psSelect.close();
> }
> - psSelect.close();
> }
> catch ( SQLException e1 )
> {
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: BCEL/JCS code repackaging (Was Re: svn commit: r1150277 - /commons/proper/jcs/trunk/src/java/org/apache/jcs/auxiliary/disk/jdbc/JDBCDiskCache.java)
Posted by Simone Tripodi <si...@apache.org>.
hi all guys,
I thought that moving from jakarta to commons community was enough to
justify a binary compatibility breakage.
have a nice day!
Simo
http://people.apache.org/~simonetripodi/
http://www.99soft.org/
On Sun, Jul 24, 2011 at 4:36 PM, Jörg Schaible <jo...@gmx.de> wrote:
> sebb wrote:
>
>> On 24 July 2011 08:15, Simone Tripodi <si...@apache.org> wrote:
>>> Hi David!!!
>>> this mail just to suggest you moving the JCS package from
>>> 'org.apache.jcs' to 'org.apache.commons.jcs'
>>> same refactoring has to be applied to BCEL, from 'org.apache.bcel' to
>>> 'org.apache.commons.bcel'
>>> HTH, have a nice day!
>>> Simo
>>
>> A package change breaks binary compatibility.
>>
>> I suggest waiting until it is required for other reasons.
>
> +1
>
> An incompatible release 2.0 is a perfect timing for such an action.
>
> - Jörg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: BCEL/JCS code repackaging (Was Re: svn commit: r1150277 - /commons/proper/jcs/trunk/src/java/org/apache/jcs/auxiliary/disk/jdbc/JDBCDiskCache.java)
Posted by Jörg Schaible <jo...@gmx.de>.
sebb wrote:
> On 24 July 2011 08:15, Simone Tripodi <si...@apache.org> wrote:
>> Hi David!!!
>> this mail just to suggest you moving the JCS package from
>> 'org.apache.jcs' to 'org.apache.commons.jcs'
>> same refactoring has to be applied to BCEL, from 'org.apache.bcel' to
>> 'org.apache.commons.bcel'
>> HTH, have a nice day!
>> Simo
>
> A package change breaks binary compatibility.
>
> I suggest waiting until it is required for other reasons.
+1
An incompatible release 2.0 is a perfect timing for such an action.
- Jörg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: BCEL/JCS code repackaging (Was Re: svn commit: r1150277 - /commons/proper/jcs/trunk/src/java/org/apache/jcs/auxiliary/disk/jdbc/JDBCDiskCache.java)
Posted by sebb <se...@gmail.com>.
On 24 July 2011 08:15, Simone Tripodi <si...@apache.org> wrote:
> Hi David!!!
> this mail just to suggest you moving the JCS package from
> 'org.apache.jcs' to 'org.apache.commons.jcs'
> same refactoring has to be applied to BCEL, from 'org.apache.bcel' to
> 'org.apache.commons.bcel'
> HTH, have a nice day!
> Simo
A package change breaks binary compatibility.
I suggest waiting until it is required for other reasons.
> http://people.apache.org/~simonetripodi/
> http://www.99soft.org/
>
>
>
> On Sun, Jul 24, 2011 at 5:57 AM, <db...@apache.org> wrote:
>> Author: dbrosius
>> Date: Sun Jul 24 03:57:18 2011
>> New Revision: 1150277
>>
>> URL: http://svn.apache.org/viewvc?rev=1150277&view=rev
>> Log:
>> remove typo of duplicate closing of jdbc statement
>>
>> Modified:
>> commons/proper/jcs/trunk/src/java/org/apache/jcs/auxiliary/disk/jdbc/JDBCDiskCache.java
>>
>> Modified: commons/proper/jcs/trunk/src/java/org/apache/jcs/auxiliary/disk/jdbc/JDBCDiskCache.java
>> URL: http://svn.apache.org/viewvc/commons/proper/jcs/trunk/src/java/org/apache/jcs/auxiliary/disk/jdbc/JDBCDiskCache.java?rev=1150277&r1=1150276&r2=1150277&view=diff
>> ==============================================================================
>> --- commons/proper/jcs/trunk/src/java/org/apache/jcs/auxiliary/disk/jdbc/JDBCDiskCache.java (original)
>> +++ commons/proper/jcs/trunk/src/java/org/apache/jcs/auxiliary/disk/jdbc/JDBCDiskCache.java Sun Jul 24 03:57:18 2011
>> @@ -476,7 +476,6 @@ public class JDBCDiskCache
>> {
>> psSelect.close();
>> }
>> - psSelect.close();
>> }
>> catch ( SQLException e1 )
>> {
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org