You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Rakesh R (Commented) (JIRA)" <ji...@apache.org> on 2011/12/21 07:53:30 UTC
[jira] [Commented] (ZOOKEEPER-1263) fix handling of min/max session
timeout value initialization
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173915#comment-13173915 ]
Rakesh R commented on ZOOKEEPER-1263:
-------------------------------------
Hi Pat, Thanks for the review and comments. I have attached latest patch with test cases.
In the patch I couldn't completely remove the conditional logic from ZooKeeperServer.
I have seen the testcases are directly instantiating the 'ZooKeeperServer' and starting the server. In this case the execution flow is not going through the ServerConfig/QuorumPeerConfig and will not be applying the defaulting logic[the timeout values will remain as -1]. So I retain the logic inside ZooKeeperServer.
> fix handling of min/max session timeout value initialization
> ------------------------------------------------------------
>
> Key: ZOOKEEPER-1263
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1263
> Project: ZooKeeper
> Issue Type: Task
> Components: server
> Reporter: Patrick Hunt
> Assignee: Rakesh R
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1263.patch, ZOOKEEPER-1263.patch
>
>
> This task rolls up the changes in subtasks for easier commit. (I'm about to submit the rolled up patch)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira