You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Abdel Hakim Deneche <ad...@maprtech.com> on 2015/02/19 04:16:12 UTC

merging pull request #6 with master

Hello parquet community,

my name is Hakim and I've been working to get pull request #6, #49 and #50
ready to merge with master.

So far I merged pull request #6 with master and all unit tests are passing,
I am still working to get #49 and #50 ready to merge (I actually got them
merged but I still have some unit tests that are failing).

You can find my changes for pull request #6 in my github repo:
https://github.com/adeneche/incubator-parquet-mr/tree/pull6-merged

Should I create a new pull request for this branch or should I contact the
author of pull request #6 to get my changes in his branch ?

Thanks!

-- 

Abdelhakim Deneche

Software Engineer

  <http://www.mapr.com/>


Now Available - Free Hadoop On-Demand Training
<http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available>

Re: merging pull request #6 with master

Posted by Abdel Hakim Deneche <ad...@maprtech.com>.
Oops

On Wed, Feb 18, 2015 at 7:26 PM, Jacques Nadeau <ja...@apache.org> wrote:

> Hey Hakim,
>
> You need to reach out to the Apache Parquet community for these, not the
> Drill community.
>
> On Wed, Feb 18, 2015 at 7:16 PM, Abdel Hakim Deneche <
> adeneche@maprtech.com>
> wrote:
>
> > Hello parquet community,
> >
> > my name is Hakim and I've been working to get pull request #6, #49 and
> #50
> > ready to merge with master.
> >
> > So far I merged pull request #6 with master and all unit tests are
> passing,
> > I am still working to get #49 and #50 ready to merge (I actually got them
> > merged but I still have some unit tests that are failing).
> >
> > You can find my changes for pull request #6 in my github repo:
> > https://github.com/adeneche/incubator-parquet-mr/tree/pull6-merged
> >
> > Should I create a new pull request for this branch or should I contact
> the
> > author of pull request #6 to get my changes in his branch ?
> >
> > Thanks!
> >
> > --
> >
> > Abdelhakim Deneche
> >
> > Software Engineer
> >
> >   <http://www.mapr.com/>
> >
> >
> > Now Available - Free Hadoop On-Demand Training
> > <
> >
> http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available
> > >
> >
>



-- 

Abdelhakim Deneche

Software Engineer

  <http://www.mapr.com/>


Now Available - Free Hadoop On-Demand Training
<http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available>

Re: merging pull request #6 with master

Posted by Jacques Nadeau <ja...@apache.org>.
Hey Hakim,

You need to reach out to the Apache Parquet community for these, not the
Drill community.

On Wed, Feb 18, 2015 at 7:16 PM, Abdel Hakim Deneche <ad...@maprtech.com>
wrote:

> Hello parquet community,
>
> my name is Hakim and I've been working to get pull request #6, #49 and #50
> ready to merge with master.
>
> So far I merged pull request #6 with master and all unit tests are passing,
> I am still working to get #49 and #50 ready to merge (I actually got them
> merged but I still have some unit tests that are failing).
>
> You can find my changes for pull request #6 in my github repo:
> https://github.com/adeneche/incubator-parquet-mr/tree/pull6-merged
>
> Should I create a new pull request for this branch or should I contact the
> author of pull request #6 to get my changes in his branch ?
>
> Thanks!
>
> --
>
> Abdelhakim Deneche
>
> Software Engineer
>
>   <http://www.mapr.com/>
>
>
> Now Available - Free Hadoop On-Demand Training
> <
> http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available
> >
>