You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "sweetpotatoman (via GitHub)" <gi...@apache.org> on 2023/02/14 08:16:23 UTC

[GitHub] [apisix-helm-chart] sweetpotatoman opened a new pull request, #469: feat: support multiple ports

sweetpotatoman opened a new pull request, #469:
URL: https://github.com/apache/apisix-helm-chart/pull/469

   feat: #404


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-helm-chart] sweetpotatoman commented on a diff in pull request #469: feat: support multiple ports

Posted by "sweetpotatoman (via GitHub)" <gi...@apache.org>.
sweetpotatoman commented on code in PR #469:
URL: https://github.com/apache/apisix-helm-chart/pull/469#discussion_r1106585399


##########
charts/apisix/templates/configmap.yaml:
##########
@@ -46,7 +46,11 @@ data:
     {{- else }}
     apisix:    # universal configurations
       {{- if not (eq .Values.deployment.role "control_plane") }}
-      node_listen: {{ .Values.gateway.http.containerPort }}    # APISIX listening port
+      node_listen:    # APISIX listening port

Review Comment:
   emm.. In order not to affect the previous, i added `additionalContainerPorts`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-helm-chart] sweetpotatoman commented on pull request #469: feat: support multiple ports

Posted by "sweetpotatoman (via GitHub)" <gi...@apache.org>.
sweetpotatoman commented on PR #469:
URL: https://github.com/apache/apisix-helm-chart/pull/469#issuecomment-1436524318

   @tao
   tao brother, need u approve.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #469: feat: support multiple ports

Posted by "tokers (via GitHub)" <gi...@apache.org>.
tokers commented on code in PR #469:
URL: https://github.com/apache/apisix-helm-chart/pull/469#discussion_r1105552645


##########
charts/apisix/values.yaml:
##########
@@ -233,6 +233,12 @@ gateway:
     enabled: true
     servicePort: 80
     containerPort: 9080
+    appendContainerPort: []

Review Comment:
   What about: `additionalContainerPorts`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #469: feat: support multiple ports

Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on PR #469:
URL: https://github.com/apache/apisix-helm-chart/pull/469#issuecomment-1451207428

   @sweetpotatoman please fix the lint error. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-helm-chart] sweetpotatoman commented on pull request #469: feat: support multiple ports

Posted by "sweetpotatoman (via GitHub)" <gi...@apache.org>.
sweetpotatoman commented on PR #469:
URL: https://github.com/apache/apisix-helm-chart/pull/469#issuecomment-1453027448

   > @sweetpotatoman please fix the lint error. Thanks
   
   fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #469: feat: support multiple ports

Posted by "tokers (via GitHub)" <gi...@apache.org>.
tokers commented on code in PR #469:
URL: https://github.com/apache/apisix-helm-chart/pull/469#discussion_r1106557444


##########
charts/apisix/templates/configmap.yaml:
##########
@@ -46,7 +46,11 @@ data:
     {{- else }}
     apisix:    # universal configurations
       {{- if not (eq .Values.deployment.role "control_plane") }}
-      node_listen: {{ .Values.gateway.http.containerPort }}    # APISIX listening port
+      node_listen:    # APISIX listening port

Review Comment:
   Could we also support multiple HTTPS ports? Not only for HTTP.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-helm-chart] sweetpotatoman commented on a diff in pull request #469: feat: support multiple ports

Posted by "sweetpotatoman (via GitHub)" <gi...@apache.org>.
sweetpotatoman commented on code in PR #469:
URL: https://github.com/apache/apisix-helm-chart/pull/469#discussion_r1105587128


##########
charts/apisix/values.yaml:
##########
@@ -233,6 +233,12 @@ gateway:
     enabled: true
     servicePort: 80
     containerPort: 9080
+    appendContainerPort: []

Review Comment:
   Good field name!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-helm-chart] tao12345666333 commented on a diff in pull request #469: feat: support multiple ports

Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on code in PR #469:
URL: https://github.com/apache/apisix-helm-chart/pull/469#discussion_r1122550211


##########
charts/apisix/templates/service-gateway.yaml:
##########
@@ -66,6 +72,10 @@ spec:
   {{- end }}
     protocol: TCP
   {{- end }}
+  {{- range .Values.gateway.tls.additionalContainerPorts }}
+  - name: apisix-gateway-tls-{{ .port | toString }}
+    port: {{ .port }}
+    targetPort: {{ .port }}

Review Comment:
   end



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #469: feat: support multiple ports

Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 merged PR #469:
URL: https://github.com/apache/apisix-helm-chart/pull/469


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org