[jira] [Commented] (MAHOUT-896) Improve readability of AbstractRecommender class

["Sean Owen (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAHOUT-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157160#comment-13157160 ] 

Sean Owen commented on MAHOUT-896:
----------------------------------

OK, do you have any specific suggestions?

The fields and methods are...

dataModel
candidateItemsStrategy

getDefaultCandidateItemsStrategy
recommend
setPreference
removePreference
getDataModel
getAllOtherItems

This seems pretty clear. This is hardly a complex class either. It also forms part of the public API.
I have a hard time imagining a naming change I would support.
                
> Improve readability of AbstractRecommender class
> ------------------------------------------------
>
>                 Key: MAHOUT-896
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-896
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Collaborative Filtering
>    Affects Versions: 0.6
>            Reporter: Anatoliy Kats
>            Assignee: Sean Owen
>            Priority: Trivial
>              Labels: newbie
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Change the variable and private method names so that they are internally consistent, and their purpose is more clear.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira