You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/11/23 19:23:07 UTC
[GitHub] [cloudstack] joseflauzino opened a new pull request #5713: Fix HostMetricsResponse unit test
joseflauzino opened a new pull request #5713:
URL: https://github.com/apache/cloudstack/pull/5713
### Description
The unit tests of class `HostMetricsResponse` will fail when they're ran on machines with `locale` other than `en_US`. This happens because locales can have distinct decimal separators, for instance, `.` in `en_US` and `,` in `pt_BR`.
This PR solves the mentioned problem by modifying the tests to use the decimal separator character according to the Locale set on the local machine (which is running the tests), instead of set it hardcoded.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### How Has This Been Tested?
I ran the unit tests of class `HostMetricsResponse` with locale `pt_BR` and `en_US`. In both cases, the tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5713: Fix HostMetricsResponse unit test
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5713:
URL: https://github.com/apache/cloudstack/pull/5713#issuecomment-979058995
@joseflauzino if you want this in 4.16.1 please rebase. otherwise just wait for a second review and we are good to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5713: Fix HostMetricsResponse unit test
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5713:
URL: https://github.com/apache/cloudstack/pull/5713#issuecomment-979016151
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5713: Fix HostMetricsResponse unit test
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5713:
URL: https://github.com/apache/cloudstack/pull/5713#issuecomment-978964354
If packaging succeeds it compiles and the test is good. No testing needed as it is a unit test only.
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi merged pull request #5713: Fix HostMetricsResponse unit test
Posted by GitBox <gi...@apache.org>.
GutoVeronezi merged pull request #5713:
URL: https://github.com/apache/cloudstack/pull/5713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #5713: Fix HostMetricsResponse unit test
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #5713:
URL: https://github.com/apache/cloudstack/pull/5713#issuecomment-979225718
Merging based on 2x LGTM (https://github.com/apache/cloudstack/pull/5713#pullrequestreview-815700415 and https://github.com/apache/cloudstack/pull/5713#pullrequestreview-815996701) and package results (https://github.com/apache/cloudstack/pull/5713#issuecomment-979016151).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] joseflauzino commented on pull request #5713: Fix HostMetricsResponse unit test
Posted by GitBox <gi...@apache.org>.
joseflauzino commented on pull request #5713:
URL: https://github.com/apache/cloudstack/pull/5713#issuecomment-979225118
@DaanHoogland we can keep in main (4.17).
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5713: Fix HostMetricsResponse unit test
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5713:
URL: https://github.com/apache/cloudstack/pull/5713#issuecomment-978964718
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org