You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/12/07 17:49:51 UTC

Review Request 64424: Removed 'total' from 'UpdateSlaveMessage'.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64424/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Jan Schlicht.


Repository: mesos


Description
-------

This field was added during the development leading up to version 1.5
in order to allow updates to agent-total resources in the context of
resource providers. It was never used in a released Mesos version.


Diffs
-----

  src/master/master.cpp 2fd66c072e9a194680d7653c664bd8a68ea1d2f0 
  src/messages/messages.proto 2ab0fe8400a2de2318368d1b408b266ce647339d 


Diff: https://reviews.apache.org/r/64424/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 64424: Removed 'total' from 'UpdateSlaveMessage'.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64424/
-----------------------------------------------------------

(Updated Dec. 8, 2017, 12:32 p.m.)


Review request for mesos, Jie Yu and Jan Schlicht.


Changes
-------

Addressed Jie's comment.


Bugs: MESOS-8312
    https://issues.apache.org/jira/browse/MESOS-8312


Repository: mesos


Description
-------

This field was added during the development leading up to version 1.5
in order to allow updates to agent-total resources in the context of
resource providers. It was never used in a released Mesos version.


Diffs (updated)
-----

  src/master/master.cpp 5cba50636a9351d29660c54fad7734fcfea547b9 
  src/messages/messages.proto f71178438660fa16aad8f290391baba7813fbff0 


Diff: https://reviews.apache.org/r/64424/diff/3/

Changes: https://reviews.apache.org/r/64424/diff/2-3/


Testing
-------

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 64424: Removed 'total' from 'UpdateSlaveMessage'.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64424/#review193217
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Dec. 8, 2017, 12:17 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64424/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2017, 12:17 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8312
>     https://issues.apache.org/jira/browse/MESOS-8312
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This field was added during the development leading up to version 1.5
> in order to allow updates to agent-total resources in the context of
> resource providers. It was never used in a released Mesos version.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 1d192db8edd36dac99ebecd17edd9a4df53a416e 
>   src/messages/messages.proto 7ab07d7a78210f4a6f418458b1484d9301710dd3 
> 
> 
> Diff: https://reviews.apache.org/r/64424/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 64424: Removed 'total' from 'UpdateSlaveMessage'.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64424/
-----------------------------------------------------------

(Updated Dec. 8, 2017, 1:17 a.m.)


Review request for mesos, Jie Yu and Jan Schlicht.


Changes
-------

Addressed comments from Jie.


Bugs: MESOS-8312
    https://issues.apache.org/jira/browse/MESOS-8312


Repository: mesos


Description
-------

This field was added during the development leading up to version 1.5
in order to allow updates to agent-total resources in the context of
resource providers. It was never used in a released Mesos version.


Diffs (updated)
-----

  src/master/master.cpp 1d192db8edd36dac99ebecd17edd9a4df53a416e 
  src/messages/messages.proto 7ab07d7a78210f4a6f418458b1484d9301710dd3 


Diff: https://reviews.apache.org/r/64424/diff/2/

Changes: https://reviews.apache.org/r/64424/diff/1-2/


Testing
-------

`make check`


Thanks,

Benjamin Bannier