You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Maron <jm...@hortonworks.com> on 2015/06/30 14:28:05 UTC
Review Request 36044: A space as the value of a command line option
ends up overwriting default value of option
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36044/
-----------------------------------------------------------
Review request for Ambari and Tom Beerbower.
Bugs: AMBARI-12214
https://issues.apache.org/jira/browse/AMBARI-12214
Repository: ambari
Description
-------
The atlas-env configuration item that ends up specifying the JVM options for the atlas server currently has a value of an empty space. That space is not ignored by the runtime, but rather used as the value for the JVM options which ends up overwriting the default value for the JVM options (-Xmx1024m). That leads to a JVM that is launched with a default JVM value of 256m, which will lead to issues when the server tries to store multiple transactions in memory.
Diffs
-----
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml aed76ff
Diff: https://reviews.apache.org/r/36044/diff/
Testing
-------
stack/python unit tests
A functional deployment with the modification in the attached patch.
Thanks,
Jonathan Maron
Re: Review Request 36044: A space as the value of a command line
option ends up overwriting default value of option
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36044/#review89888
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On June 30, 2015, 12:28 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36044/
> -----------------------------------------------------------
>
> (Updated June 30, 2015, 12:28 p.m.)
>
>
> Review request for Ambari and Tom Beerbower.
>
>
> Bugs: AMBARI-12214
> https://issues.apache.org/jira/browse/AMBARI-12214
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The atlas-env configuration item that ends up specifying the JVM options for the atlas server currently has a value of an empty space. That space is not ignored by the runtime, but rather used as the value for the JVM options which ends up overwriting the default value for the JVM options (-Xmx1024m). That leads to a JVM that is launched with a default JVM value of 256m, which will lead to issues when the server tries to store multiple transactions in memory.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml aed76ff
>
> Diff: https://reviews.apache.org/r/36044/diff/
>
>
> Testing
> -------
>
> stack/python unit tests
> A functional deployment with the modification in the attached patch.
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 36044: A space as the value of a command line
option ends up overwriting default value of option
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36044/#review89889
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On June 30, 2015, 12:28 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36044/
> -----------------------------------------------------------
>
> (Updated June 30, 2015, 12:28 p.m.)
>
>
> Review request for Ambari and Tom Beerbower.
>
>
> Bugs: AMBARI-12214
> https://issues.apache.org/jira/browse/AMBARI-12214
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The atlas-env configuration item that ends up specifying the JVM options for the atlas server currently has a value of an empty space. That space is not ignored by the runtime, but rather used as the value for the JVM options which ends up overwriting the default value for the JVM options (-Xmx1024m). That leads to a JVM that is launched with a default JVM value of 256m, which will lead to issues when the server tries to store multiple transactions in memory.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml aed76ff
>
> Diff: https://reviews.apache.org/r/36044/diff/
>
>
> Testing
> -------
>
> stack/python unit tests
> A functional deployment with the modification in the attached patch.
>
>
> Thanks,
>
> Jonathan Maron
>
>