[jira] [Commented] (HDFS-4354) Create DomainSocket and DomainPeer and associated unit tests

["Todd Lipcon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543407#comment-13543407 ] 

Todd Lipcon commented on HDFS-4354:
-----------------------------------

I reviewed just the new parts in this patch since HDFS-4353. Also worth noting that there were a few rounds done on this code earlier in https://reviews.apache.org/r/8554/. So, only a few small comments here:

----

{code}
+  /**
+   * Return true only if UNIX domain sockets are available.
+   */
+  public static String getLoadingFailureReason() {
{code}

Javadoc is mistaken

----
{code}
+    assert newCount >= 0;
{code}
Don't you mean {{newCount & ~STATUS_CLOSED_MASK}}?

Might be nice to define {{private static final int STATUS_REFCOUNT_MASK = ~STATUS_CLOSED_MASK}} as well.

---
Otherwise looks pretty good, but I'll wait for a broken-out patch before giving a +1.
                
> Create DomainSocket and DomainPeer and associated unit tests
> ------------------------------------------------------------
>
>                 Key: HDFS-4354
>                 URL: https://issues.apache.org/jira/browse/HDFS-4354
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, hdfs-client, performance
>    Affects Versions: 2.0.3-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: 03-cumulative.patch
>
>
> Create {{DomainSocket}}, a JNI class which provides UNIX domain sockets functionality in Java.  Also create {{DomainPeer}}, {{DomainPeerServer}}.  This change also adds a unit test as well as {{TemporarySocketDirectory}}.
> Finally, this change adds a few C utility methods for handling JNI exceptions, such as {{newException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira