[GitHub] [helix] narendly commented on pull request #1562: Fix ZkClient leakage by correctly setting usesExternalZkClient flag

[GitBox <gi...@apache.org>]

narendly commented on pull request #1562:
URL: https://github.com/apache/helix/pull/1562#issuecomment-755572659


   This PR is ready to be merged.
   
   ZkBaseDataAccessor and Helix API that uses it using its Builder were having zkClient thread leak issues because the usesExternalZkClient flag was not being set properly. Also, the family of Verifiers were having a similar issue. This change solves this by making sure the private/protected constructors used by the Builders of these classes set the flag correctly to false so that in their respective close() functions, the underlying zkClient (created by the Builder) would get closed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org