You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jieshan Bean (Created) (JIRA)" <ji...@apache.org> on 2012/02/14 10:39:59 UTC
[jira] [Created] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Handle the regions in regionPlans while processing ServerShutdownHandler
------------------------------------------------------------------------
Key: HBASE-5396
URL: https://issues.apache.org/jira/browse/HBASE-5396
Project: HBase
Issue Type: Bug
Components: master
Affects Versions: 0.90.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
Fix For: 0.94.0
The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Jieshan Bean (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208227#comment-13208227 ]
Jieshan Bean commented on HBASE-5396:
-------------------------------------
ok..I rename it as "regionsOnServer". I will upload the new patch after tests. Thanks, Ted.
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.90.7
>
> Attachments: HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212370#comment-13212370 ]
stack commented on HBASE-5396:
------------------------------
If you found it in 0.92, thats good enough -- its in TRUNK I'd say.
Do you have more of the regionserver log? Why does it say its aborting? You don't have it in your log above (The logs above look 'normal'.. we need to bits that show it gone awry... thanks Jieshan).
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-final.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch, HBASE-5396-92.patch, HBASE-5396-trunk.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Jieshan Bean (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213349#comment-13213349 ]
Jieshan Bean commented on HBASE-5396:
-------------------------------------
@stack,
RegionServer process was killed manually. Not aborted itself. This is the steps of my test:
Suppose there's 3 nodes in cluster: A, B, C.
1. Create a table with 1000 regions.
2. Assign all regions to C.
3. Kill C. During the ServerShutdownHandler processing, then kill A(At this time, some regions may been openning on this server.)
See whether all the regions can be opened in time(And also check the regions which in regionPlans).
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-final.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch, HBASE-5396-92.patch, HBASE-5396-trunk.patch, Logs-TestFor92.rar
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Jieshan Bean (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jieshan Bean updated HBASE-5396:
--------------------------------
Attachment: (was: HBASE-5396-90-forReview.patch)
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.90.7
>
> Attachments: HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213335#comment-13213335 ]
stack commented on HBASE-5396:
------------------------------
The log does not show the regionserver aborting. Should it? Or am I misunderstanding (I guess I'm not clear on what I should be looking for in this log. Please help me Jieshan. Sorry for being a bit slow).
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-final.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch, HBASE-5396-92.patch, HBASE-5396-trunk.patch, Logs-TestFor92.rar
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Jieshan Bean (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212352#comment-13212352 ]
Jieshan Bean commented on HBASE-5396:
-------------------------------------
RegionServer Log:
{noformat}
2012-02-20 23:24:49,432 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign: regionserver:20020-0x3359b077bc90018 Attempting to transition node 897ad476f426e58a36cae77c7302be1d from M_ZK_REGION_OFFLINE to RS_ZK_REGION_OPENING
2012-02-20 23:24:49,447 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign: regionserver:20020-0x3359b077bc90018 Successfully transitioned node 897ad476f426e58a36cae77c7302be1d from M_ZK_REGION_OFFLINE to RS_ZK_REGION_OPENING
2012-02-20 23:24:49,448 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Opening region: {NAME => 'jeason,001477777777,1329747764680.897ad476f426e58a36cae77c7302be1d.', STARTKEY => '001477777777', ENDKEY => '001488888888', ENCODED => 897ad476f426e58a36cae77c7302be1d,}
2012-02-20 23:24:49,448 INFO org.apache.hadoop.hbase.regionserver.HRegion: Setting up tabledescriptor config now ...
2012-02-20 23:24:49,448 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Instantiated jeason,001477777777,1329747764680.897ad476f426e58a36cae77c7302be1d.
2012-02-20 23:24:49,455 INFO org.apache.hadoop.hbase.regionserver.HRegion: Onlined jeason,001477777777,1329747764680.897ad476f426e58a36cae77c7302be1d.; next sequenceid=1
//This regionserver was killed just after the below log.
2012-02-20 23:24:49,455 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign: regionserver:20020-0x3359b077bc90018 Attempting to transition node 897ad476f426e58a36cae77c7302be1d from RS_ZK_REGION_OPENING to RS_ZK_REGION_OPENING
{noformat}
HMaster Log:
{noformat}
2012-02-20 23:25:36,442 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Assigning region jeason,001477777777,1329747764680.897ad476f426e58a36cae77c7302be1d. to C3S32,20020,1329798176762
2012-02-20 23:25:36,442 DEBUG org.apache.hadoop.hbase.master.ServerManager: New connection to C3S32,20020,1329798176762
2012-02-20 23:25:36,462 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Handling transition=RS_ZK_REGION_OPENED, server=C3S32,20020,1329798176762, region=561e68708199320894bfcfc533cae772
2012-02-20 23:25:36,462 DEBUG org.apache.hadoop.hbase.master.handler.OpenedRegionHandler: Handling OPENED event for jeason,001377777777,1329747764680.561e68708199320894bfcfc533cae772. from C3S32,20020,1329798176762; deleting unassigned node
2012-02-20 23:25:36,462 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign: master:20000-0x2359b0778ec000d Deleting existing unassigned node for 561e68708199320894bfcfc533cae772 that is in expected state RS_ZK_REGION_OPENED
2012-02-20 23:25:36,463 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Handling transition=RS_ZK_REGION_OPENING, server=C3S32,20020,1329798176762, region=3455f468b76dcf7cfe3881f9e156d0c8
2012-02-20 23:25:36,468 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign: master:20000-0x2359b0778ec000d Successfully deleted unassigned node for region 561e68708199320894bfcfc533cae772 in expected state RS_ZK_REGION_OPENED
2012-02-20 23:25:36,468 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: The znode of region jeason,001377777777,1329747764680.561e68708199320894bfcfc533cae772. has been deleted.
2012-02-20 23:25:36,468 INFO org.apache.hadoop.hbase.master.AssignmentManager: The master has opened the region jeason,001377777777,1329747764680.561e68708199320894bfcfc533cae772. that was online on C3S32,20020,1329798176762
2012-02-20 23:25:36,472 INFO org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: 1 regions which planned to open on C3S31,20020,1329798177361 be re-assigned.
{noformat}
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-final.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch, HBASE-5396-92.patch, HBASE-5396-trunk.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207860#comment-13207860 ]
Zhihong Yu commented on HBASE-5396:
-----------------------------------
{code}
+ && regionPlanOnThisServer != null
+ && !regionPlanOnThisServer.contains(rit.getRegion())) {
{code}
Did you mean this ?
{code}
+ && (regionsOnServer == null
+ || !regionsOnServer.contains(rit.getRegion()))) {
{code}
As I said above, if regionsOnServer was initialized to empty Set, the null check above can be omitted.
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.90.7
>
> Attachments: HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208223#comment-13208223 ]
Zhihong Yu commented on HBASE-5396:
-----------------------------------
If you agree with renaming RegionsWithDeadServer to DeadServerWithRegions, I think regionsOnServer should be more suitable with DeadServerWithRegions. Basically it means region info's on the dead server.
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.90.7
>
> Attachments: HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Jieshan Bean (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jieshan Bean updated HBASE-5396:
--------------------------------
Attachment: HBASE-5396-90-final.patch
Sometime, it's really hard to get a good name.
I've changed it in "HBASE-5396-90-final.patch". Thanks Ted.
I will make the patch for TRUNK today.
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.90.7
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-final.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5396:
------------------------------
Fix Version/s: (was: 0.90.7)
0.92.1
0.90.6
0.94.0
Hadoop Flags: Reviewed
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-final.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Jieshan Bean (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jieshan Bean updated HBASE-5396:
--------------------------------
Attachment: HBASE-5396-90-forReview.patch
This patch was modified basing on the above comments. I upload it just for review. Plz share your comment again if possible. Then I will start the tests.
Thanks Stack & Ted.
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.90.7
>
> Attachments: HBASE-5396-90-forReview.patch, HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209124#comment-13209124 ]
Zhihong Yu commented on HBASE-5396:
-----------------------------------
Test result for latest patch is positive.
HBASE-5396-90-final.patch is good to go for 0.90 branch
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.90.7
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-final.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209104#comment-13209104 ]
Zhihong Yu commented on HBASE-5396:
-----------------------------------
+1 on patch for 90. Running test suite.
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.90.7
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-final.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Jieshan Bean (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211917#comment-13211917 ]
Jieshan Bean commented on HBASE-5396:
-------------------------------------
I tested the patch for 92 by unit test and also in real cluster. This problem seems not represent in 92 and trunk version. I will give more tests and went through the code to check whether it's necessary for 92 and trunk.
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-final.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Jieshan Bean (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jieshan Bean updated HBASE-5396:
--------------------------------
Attachment: HBASE-5396-trunk.patch
HBASE-5396-92.patch
That problem is still there in 92 and trunk..but difficult to reproduce..After more tests, I reproduced it and verified the patch for 92. I haven't tested the patch for trunk.
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-final.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch, HBASE-5396-92.patch, HBASE-5396-trunk.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257508#comment-13257508 ]
ramkrishna.s.vasudevan commented on HBASE-5396:
-----------------------------------------------
BTW,
do we need to put this into 0.92 and above?
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.92.2
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-final.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch, HBASE-5396-92.patch, HBASE-5396-trunk.patch, Logs-TestFor92.rar
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213374#comment-13213374 ]
stack commented on HBASE-5396:
------------------------------
So what am I looking to see in the log snippet above (and in the attached log?) Thanks Jieshan.
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-final.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch, HBASE-5396-92.patch, HBASE-5396-trunk.patch, Logs-TestFor92.rar
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209517#comment-13209517 ]
ramkrishna.s.vasudevan commented on HBASE-5396:
-----------------------------------------------
Committed to 0.90. Once Jieshan gives patch for trunk will commit to 0.92 and trunk.
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-final.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208384#comment-13208384 ]
Zhihong Yu commented on HBASE-5396:
-----------------------------------
{code}
+ // Store the related regions in regionPlans.
+ regionsOpeningOnServer.add(e.getValue().getRegionInfo());
{code}
In order to make field name consistent with the above javadoc, how about naming it regionsFromRegionPlansForServer so that its source is clear ?
Also, please take a look at TRUNK and be prepared for TRUNK patch after 0.90 fix is finalized.
Thanks for the hard work.
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.90.7
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Jieshan Bean (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212357#comment-13212357 ]
Jieshan Bean commented on HBASE-5396:
-------------------------------------
I'm running the unit tests for TRUNK.
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-final.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch, HBASE-5396-92.patch, HBASE-5396-trunk.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Jieshan Bean (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jieshan Bean updated HBASE-5396:
--------------------------------
Attachment: HBASE-5396-90-forReview.patch
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.90.7
>
> Attachments: HBASE-5396-90-forReview.patch, HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Jieshan Bean (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213237#comment-13213237 ]
Jieshan Bean commented on HBASE-5396:
-------------------------------------
All tests passed for TRUNK.
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-final.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch, HBASE-5396-92.patch, HBASE-5396-trunk.patch, Logs-TestFor92.rar
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207856#comment-13207856 ]
Zhihong Yu commented on HBASE-5396:
-----------------------------------
@Jieshan:
Have you tested your patch in a 0.90 cluster ?
{code}
+ public boolean isRegionOnline(HRegionInfo hri) {
+ HServerInfo hsi = this.regions.get(hri);
+ if (hsi != null && this.isServerOnline(hsi.getServerName())) {
{code}
If hsi isn't online, should we remove region to server assignment mapping for hsi ?
For RegionsWithDeadServer, would DeadServerWithRegions be a better name ?
{code}
+ private Set<HRegionInfo> regionPlanOnThisServer = null;
{code}
Since the member of the Set isn't RegionPlan, I suggest renaming the above field to regionsOnServer.
Also, I think regionsOnServer and regionsInTransition should be initialized with empty HashSet. This would potentially avoid NPE in a few places.
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.90.7
>
> Attachments: HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Jieshan Bean (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208222#comment-13208222 ]
Jieshan Bean commented on HBASE-5396:
-------------------------------------
Thanks, Ted. Only one doubt basing on your comments:
bq.Since the member of the Set isn't RegionPlan, I suggest renaming the above field to regionsOnServer.
Since the Set came from the regionPlans. So can I keep this name as regionPlanOnThisServer? I think regionsOnServer will bring some misunderstanding. right?
I have test this patch in 90 cluster for many times. And it works fine. I will upload the new patch today.
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.90.7
>
> Attachments: HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Jieshan Bean (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jieshan Bean updated HBASE-5396:
--------------------------------
Attachment: HBASE-5396-90.patch
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.90.7
>
> Attachments: HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Jieshan Bean (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jieshan Bean updated HBASE-5396:
--------------------------------
Attachment: HBASE-5396-90-V2.patch
I renamed "regionPlanOnThisServer" to "regionOpeningOnServer", for emphasizing those regions were being processed when this HRegionServer been killed.
Since the class name is "RegionsOnDeadServer", and "regionPlanOnThisServer" can be distinguished from it.
{noformat}
public RegionsOnDeadServer processServerShutdown(final HServerInfo hsi) {
RegionsOnDeadServer regionsOnDeadServer = new RegionsOnDeadServer();
Set<HRegionInfo> regionsOpeningOnServer = new HashSet<HRegionInfo>();
{noformat}
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.90.7
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212107#comment-13212107 ]
stack commented on HBASE-5396:
------------------------------
@Jieshan Thats interesting. Thanks for checking it out. Why do we not have the prob. in 0.92/trunk? Is code different?
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-final.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Jieshan Bean (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208378#comment-13208378 ]
Jieshan Bean commented on HBASE-5396:
-------------------------------------
All tests passed. And I also tested it in real cluster.
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.90.7
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Jieshan Bean (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213381#comment-13213381 ]
Jieshan Bean commented on HBASE-5396:
-------------------------------------
Only see the below and related logs. It means the region in regionPlans can be reassigned with this patch.
{noformat}
2012-02-20 23:25:36,472 INFO org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: 1 regions which planned to open on C3S31,20020,1329798177361 be re-assigned.
{noformat}
Thanks, Stack.
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-final.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch, HBASE-5396-92.patch, HBASE-5396-trunk.patch, Logs-TestFor92.rar
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208239#comment-13208239 ]
stack commented on HBASE-5396:
------------------------------
On the below:
{code}
+ public boolean isRegionOnline(HRegionInfo hri) {
+ HServerInfo hsi = this.regions.get(hri);
+ if (hsi != null && this.isServerOnline(hsi.getServerName())) {
+ return true;
+ }
+ return false;
+ }
{code}
Don't you have to take out a lock on this.regions before you access it? See the comment in this.servers.
Also, could write the end of the method so:
{code}
return hsi != null && this.isServerOnline(hsi.getServerName();
{code}
Whats a RegionsWithDeadServer? Is it RegionsOnDeadServers?
The below is called regionplan but its storing HRegionInfos?
{code}
+ Set<HRegionInfo> regionPlanOnThisServer = new HashSet<HRegionInfo>();
{code}
And then here, we are storing a Set of HRIs but method name talks of RegionPlans. Its a little hard to follow?
Ditto here:
{code}
+ private Set<HRegionInfo> regionPlanOnThisServer = null;
{code}
and this...
{code}
+ public Set<HRegionInfo> getRegionPlanOnThisServer() {
{code}
This comment doesn't seem right?
{code}
+ * Process result used by processServerShutdown.
{code}
There is no processing done in this data structure.
... and save a few lines?
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.90.7
>
> Attachments: HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Jieshan Bean (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jieshan Bean updated HBASE-5396:
--------------------------------
Fix Version/s: (was: 0.94.0)
0.90.7
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.90.7
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5396) Handle the regions in regionPlans
while processing ServerShutdownHandler
Posted by "Jieshan Bean (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jieshan Bean updated HBASE-5396:
--------------------------------
Attachment: Logs-TestFor92.rar
This is the complete logs. I added some logs to track. And add sleeping code in opening to enlarge the proability of this problem.
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.0, 0.90.6, 0.92.1
>
> Attachments: HBASE-5396-90-V2.patch, HBASE-5396-90-final.patch, HBASE-5396-90-forReview.patch, HBASE-5396-90.patch, HBASE-5396-92.patch, HBASE-5396-trunk.patch, Logs-TestFor92.rar
>
>
> The regions plan to open on this server while ServerShutdownHandler is handling, just be removed from AM.regionPlans, and only left to TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira