You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by michellephung <gi...@git.apache.org> on 2015/02/18 20:03:20 UTC
[GitHub] couchdb-fauxton pull request: Erase console logs in api.js
GitHub user michellephung opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/276
Erase console logs in api.js
These were left in with commit 92834eae02eadc361de3a21ee1079d8f47af6492 (Centralize URLs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michellephung/couchdb-fauxton erase-console-logs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/276.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #276
----
commit 42fb7cf3a0307b3a5e5ba176b96de8f59f9749c1
Author: michellephung@gmail.com <mi...@gmail.com>
Date: 2015-02-18T19:00:23Z
Erase console logs in api.js
These were left in with commit 92834eae02eadc361de3a21ee1079d8f47af6492 (Centralize URLs)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Erase console logs in api.js
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/276#issuecomment-74931514
Oh! I thought they are there for making debugging easier as they just log if something fails so the functions do not fail silently?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Erase console logs in api.js
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/276
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Erase console logs in api.js
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/276#issuecomment-75155693
yes, as they notice the developer if the routes are wrong.
maybe change it to a `console.error` instead or even throw an error `throw new Error('could not find name: ' + name);`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Erase console logs in api.js
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/276#issuecomment-74941166
they are for debugging, should we leave them in ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Erase console logs in api.js
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/276#issuecomment-76369786
merged as 73bacedae20d6eaeefa0607364c79c94ad862844 - thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---