[jira] [Reopened] (DELTASPIKE-940) @Transactional and @EntityManagerConfig each use a different method to resolve EntityManagers

["Matej Novotny (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DELTASPIKE-940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matej Novotny reopened DELTASPIKE-940:
--------------------------------------

Commits for this issue break 120 tests in the module (over 2/3 of all tests in the module) on both WFLY and Tomee.

> @Transactional and @EntityManagerConfig each use a different method to resolve EntityManagers
> ---------------------------------------------------------------------------------------------
>
>                 Key: DELTASPIKE-940
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-940
>             Project: DeltaSpike
>          Issue Type: Improvement
>          Components: Data-Module, JPA-Module
>            Reporter: Xavier Dury
>            Assignee: John D. Ament
>            Priority: Minor
>             Fix For: 1.8.1
>
>         Attachments: ds940.patch
>
>
> When an application uses multiple {{EntityManager}}'s, there must be a way to specify which one(s) should be used. Currently, {{@Transactional}} and {{@EntityManagerConfig}} use different approaches:
> - {{@Transactional}} can take one or more qualifiers directly in its {{qualifier()}} member ({{@Transactional(qualifier = MyDB.class)}})
> - While {{@EntityManagerConfig}} must define an {{EntityManagerResolver}} ({{@EntityManagerConfig(entityManagerResolver = MyDBEntityManagerResolver.class}})
> I think both should be unified and use a single way to specify which {{EntityManager}} to use. IMHO, the {{@Transactional}} way of doing looks better and should be applied to {{@EntityManagerConfig}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)