You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/08 17:17:48 UTC

[GitHub] [superset] graceguo-supercat opened a new issue #12355: [line chart] new Line chart does not have x-axis control

graceguo-supercat opened a new issue #12355:
URL: https://github.com/apache/superset/issues/12355


   - nvd3 line chart has x-axis control:
   
   
   <img width="1156" alt="Screen Shot 2021-01-08 at 9 14 03 AM" src="https://user-images.githubusercontent.com/27990562/104044300-0243b980-5192-11eb-8605-79bb051f376b.png">
   
   
   - echart version does not have x-axis control:
   <img width="1210" alt="Screen Shot 2021-01-08 at 9 14 37 AM" src="https://user-images.githubusercontent.com/27990562/104044392-1d162e00-5192-11eb-9ac9-870d62ef6266.png">
   
   
   Could we add a-axis format in eChart version?
   @junlincc @villebro 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc edited a comment on issue #12355: [line chart] new Line chart does not have x-axis control

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #12355:
URL: https://github.com/apache/superset/issues/12355#issuecomment-756924636


   Echarts 5.0 automatically cut the ticks optimally based on the data time range and time grain setting, that's why we are seeing "inconsistent" format on the x-axis. 
   
   ![image](https://user-images.githubusercontent.com/67837651/104050564-a847f180-519b-11eb-9b42-11048b611d64.png)
   
   We can certainly add a formatter in the Echarts, but the question is, do we want them to work exactly as nvd3 charts? 
   Can we schedule a session with your users to understand the request better before diving in any implementation. @graceguo-supercat @zuzana-vej 
   
   cc @eugeniamz 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] graceguo-supercat commented on issue #12355: [chart] Echarts time-series chart does not have x-axis control

Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #12355:
URL: https://github.com/apache/superset/issues/12355#issuecomment-757076616


   Not urgent at all. At least we have nvd3 line chart to use. If this request can be added to the long term roadmap will be great, at least before fully deprecating nvd3 line chart. Thank you @junlincc 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #12355: [line chart] new Line chart does not have x-axis control

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12355:
URL: https://github.com/apache/superset/issues/12355#issuecomment-756924636


   Echarts 5.0 automatically cut the ticks optimally based on the data time range and time grain setting, that's why we are seeing "inconsistent" format on the x-axis. 
   
   ![image (2)](https://user-images.githubusercontent.com/67837651/104050550-a4b46a80-519b-11eb-9458-6ff5006b3343.png)
   ![image](https://user-images.githubusercontent.com/67837651/104050564-a847f180-519b-11eb-9b42-11048b611d64.png)
   
   We can certainly add a formatter in the Echarts, but the question is, do we want them to work exactly as nvd3 charts? 
   Can we schedule a session with your users to understand the request better before diving in any implementation. @graceguo-supercat @zuzana-vej 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] eugeniamz commented on issue #12355: [chart] Echarts time-series line chart does not have x-axis control

Posted by GitBox <gi...@apache.org>.
eugeniamz commented on issue #12355:
URL: https://github.com/apache/superset/issues/12355#issuecomment-757910456


   @junlincc  yes, I think x-axis control and customization should be useful 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro commented on issue #12355: [chart] Echarts time-series line chart does not have x-axis control

Posted by GitBox <gi...@apache.org>.
villebro commented on issue #12355:
URL: https://github.com/apache/superset/issues/12355#issuecomment-757925214


   I believe @maloun96 is currently working on adding x-axis formatting support as a byproduct of another feature, so this may be fixed sooner rather than later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #12355: [chart] Echarts time-series chart does not have x-axis control

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12355:
URL: https://github.com/apache/superset/issues/12355#issuecomment-757028660


   we probably can do something simple for now. we don't have much planed around Echarts in Q1. do you have a timeline? @graceguo-supercat 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] graceguo-supercat commented on issue #12355: [chart] Echarts time-series chart does not have x-axis control

Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #12355:
URL: https://github.com/apache/superset/issues/12355#issuecomment-756940809






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #12355: [chart] Echarts time-series line chart does not have x-axis control

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12355:
URL: https://github.com/apache/superset/issues/12355#issuecomment-766392457


   confirmed this feature is available in TimeSeries Echarts in master now. thank you @maloun96 for the enhancement! 
   @graceguo-supercat @zuzana-vej 
   
   https://user-images.githubusercontent.com/67837651/105637127-ada26e80-5e20-11eb-85b7-7d8e431af996.mov
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc closed issue #12355: [chart] Echarts time-series line chart does not have x-axis control

Posted by GitBox <gi...@apache.org>.
junlincc closed issue #12355:
URL: https://github.com/apache/superset/issues/12355


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc closed issue #12355: [chart] Echarts time-series line chart does not have x-axis control

Posted by GitBox <gi...@apache.org>.
junlincc closed issue #12355:
URL: https://github.com/apache/superset/issues/12355


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #12355: [chart] Echarts time-series line chart does not have x-axis control

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12355:
URL: https://github.com/apache/superset/issues/12355#issuecomment-766392457


   confirmed this feature is available in TimeSeries Echarts in master now. thank you @maloun96 for the enhancement! 
   @graceguo-supercat @zuzana-vej 
   
   https://user-images.githubusercontent.com/67837651/105637127-ada26e80-5e20-11eb-85b7-7d8e431af996.mov
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #12355: [line chart] new Line chart does not have x-axis control

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12355:
URL: https://github.com/apache/superset/issues/12355#issuecomment-756924636






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] zufolo441 commented on issue #12355: [chart] Echarts time-series line chart does not have x-axis control

Posted by GitBox <gi...@apache.org>.
zufolo441 commented on issue #12355:
URL: https://github.com/apache/superset/issues/12355#issuecomment-758680724


   @eugeniamz 
   
   thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] zufolo441 commented on issue #12355: [chart] Echarts time-series line chart does not have x-axis control

Posted by GitBox <gi...@apache.org>.
zufolo441 commented on issue #12355:
URL: https://github.com/apache/superset/issues/12355#issuecomment-757905704


   Hi all, 
   I'm searching for echarts version of line chart in chart list, but I'm not able to find it. git version of today.
   
   ![Screenshot_20210111_125631](https://user-images.githubusercontent.com/45826835/104179662-843f1700-540c-11eb-98cf-52f410ad3546.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc edited a comment on issue #12355: [line chart] new Line chart does not have x-axis control

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #12355:
URL: https://github.com/apache/superset/issues/12355#issuecomment-756924636


   Echarts 5.0 automatically cut the ticks optimally based on the data time range and time grain setting, that's why we are seeing "inconsistent" format on the x-axis. 
   
   ![image](https://user-images.githubusercontent.com/67837651/104050564-a847f180-519b-11eb-9b42-11048b611d64.png)
   
   We can certainly add a formatter in the Echarts, but the question is, do we want them to work exactly as nvd3 charts? 
   Can we schedule a session with your users to understand the request better before diving in any implementation. @graceguo-supercat @zuzana-vej 
   
   cc @eugeniamz 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] graceguo-supercat commented on issue #12355: [chart] Echarts time-series chart does not have x-axis control

Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #12355:
URL: https://github.com/apache/superset/issues/12355#issuecomment-756940809


   > do we want them to work exactly as nvd3 charts?
   
   No. We only want to have a control to format x-axis, for example to show only month, or month/year etc. 
   <img width="341" alt="Screen Shot 2021-01-08 at 11 02 31 AM" src="https://user-images.githubusercontent.com/27990562/104054016-235fd680-51a1-11eb-937f-50468270fc7a.png">
   Right now is nothing user can choose.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] eugeniamz commented on issue #12355: [chart] Echarts time-series line chart does not have x-axis control

Posted by GitBox <gi...@apache.org>.
eugeniamz commented on issue #12355:
URL: https://github.com/apache/superset/issues/12355#issuecomment-757909968


   @zufolo441, it is a time series chart 
   ![image](https://user-images.githubusercontent.com/58375897/104180659-7cb34a00-53db-11eb-89be-4b24755f25a0.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org