You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/08 08:17:19 UTC

[GitHub] [apisix-ingress-controller] AlinsRan commented on a diff in pull request #1489: e2e: support docker hub as registry

AlinsRan commented on code in PR #1489:
URL: https://github.com/apache/apisix-ingress-controller/pull/1489#discussion_r1043049563


##########
test/e2e/scaffold/apisix.go:
##########
@@ -72,7 +72,7 @@ spec:
             tcpSocket:
               port: 9080
             timeoutSeconds: 2
-          image: "localhost:5000/apache/apisix:dev"
+          image: "localhost:5000/apisix:dev"

Review Comment:
   Relevant processing logic already exists.
   https://github.com/apache/apisix-ingress-controller/blob/master/test/e2e/scaffold/scaffold.go#L588



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org