[GitHub] [spark] tgravescs commented on a diff in pull request #38622: [SPARK-39601][YARN] AllocationFailure should not be treated as exitCausedByApp when driver is shutting down

[GitBox <gi...@apache.org>]

tgravescs commented on code in PR #38622:
URL: https://github.com/apache/spark/pull/38622#discussion_r1021695959


##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala:
##########
@@ -815,6 +815,7 @@ private[spark] class ApplicationMaster(
       case Shutdown(code) =>
         exitCode = code
         shutdown = true
+        allocator.setShutdown(true)

Review Comment:
   so maybe I'm missing a call but it looks like this  Shutdown message is only sent in Client mode.  Is that the only time you are seeing this issue?  ie when you have the driver is local and the applicationmaster and yarn allocator are on the cluster?
   But the log message in the description has YarnClusterSchedulerBackend which makes me think this is cluster mode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org