You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Richard Liang (JIRA)" <ji...@apache.org> on 2006/04/26 03:54:02 UTC

[jira] Created: (HARMONY-412) test/java/tests/api/java/net/SocketTest.java doesn't follow JUnit exception handling convention.

test/java/tests/api/java/net/SocketTest.java doesn't follow JUnit exception handling convention.
------------------------------------------------------------------------------------------------

         Key: HARMONY-412
         URL: http://issues.apache.org/jira/browse/HARMONY-412
     Project: Harmony
        Type: Test

  Components: Classlib  
    Reporter: Richard Liang
    Priority: Minor


test/java/tests/api/java/net/SocketTest.java doesn't follow JUnit exception handling convention.
I'll upload a patch soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-412) test/java/tests/api/java/net/SocketTest.java doesn't follow JUnit exception handling convention.

Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-412?page=all ]

Richard Liang updated HARMONY-412:
----------------------------------

    Attachment: luni.test.diff

Hello,

This patch fixes bad exception handling code in SocketTest.java.

Would you please have a try? 

Thanks!

> test/java/tests/api/java/net/SocketTest.java doesn't follow JUnit exception handling convention.
> ------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-412
>          URL: http://issues.apache.org/jira/browse/HARMONY-412
>      Project: Harmony
>         Type: Test

>   Components: Classlib
>     Reporter: Richard Liang
>     Priority: Minor
>  Attachments: luni.test.diff
>
> test/java/tests/api/java/net/SocketTest.java doesn't follow JUnit exception handling convention.
> I'll upload a patch soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (HARMONY-412) test/java/tests/api/java/net/SocketTest.java doesn't follow JUnit exception handling convention.

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-412?page=all ]
     
Stepan Mishura resolved HARMONY-412:
------------------------------------

    Resolution: Fixed

Thanks Richard,

Patch was applied to LUNI module at repo revision 397522.

Please check that the patch was applied as you expected. (I've got strange commit notification with message: [... 31 lines stripped ...] )


> test/java/tests/api/java/net/SocketTest.java doesn't follow JUnit exception handling convention.
> ------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-412
>          URL: http://issues.apache.org/jira/browse/HARMONY-412
>      Project: Harmony
>         Type: Test

>   Components: Classlib
>     Reporter: Richard Liang
>     Assignee: Stepan Mishura
>     Priority: Minor
>  Attachments: luni.test.diff
>
> test/java/tests/api/java/net/SocketTest.java doesn't follow JUnit exception handling convention.
> I'll upload a patch soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-412) test/java/tests/api/java/net/SocketTest.java doesn't follow JUnit exception handling convention.

Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-412?page=comments#action_12376903 ] 

Richard Liang commented on HARMONY-412:
---------------------------------------

Hello Stepan, 

The fix works fine for me. Please close this issue. Thanks a lot. :-)

> test/java/tests/api/java/net/SocketTest.java doesn't follow JUnit exception handling convention.
> ------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-412
>          URL: http://issues.apache.org/jira/browse/HARMONY-412
>      Project: Harmony
>         Type: Test

>   Components: Classlib
>     Reporter: Richard Liang
>     Assignee: Stepan Mishura
>     Priority: Minor
>  Attachments: luni.test.diff
>
> test/java/tests/api/java/net/SocketTest.java doesn't follow JUnit exception handling convention.
> I'll upload a patch soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (HARMONY-412) test/java/tests/api/java/net/SocketTest.java doesn't follow JUnit exception handling convention.

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-412?page=all ]
     
Stepan Mishura closed HARMONY-412:
----------------------------------


Verified by Richard

> test/java/tests/api/java/net/SocketTest.java doesn't follow JUnit exception handling convention.
> ------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-412
>          URL: http://issues.apache.org/jira/browse/HARMONY-412
>      Project: Harmony
>         Type: Test

>   Components: Classlib
>     Reporter: Richard Liang
>     Assignee: Stepan Mishura
>     Priority: Minor
>  Attachments: luni.test.diff
>
> test/java/tests/api/java/net/SocketTest.java doesn't follow JUnit exception handling convention.
> I'll upload a patch soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (HARMONY-412) test/java/tests/api/java/net/SocketTest.java doesn't follow JUnit exception handling convention.

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-412?page=all ]

Stepan Mishura reassigned HARMONY-412:
--------------------------------------

    Assign To: Stepan Mishura

> test/java/tests/api/java/net/SocketTest.java doesn't follow JUnit exception handling convention.
> ------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-412
>          URL: http://issues.apache.org/jira/browse/HARMONY-412
>      Project: Harmony
>         Type: Test

>   Components: Classlib
>     Reporter: Richard Liang
>     Assignee: Stepan Mishura
>     Priority: Minor
>  Attachments: luni.test.diff
>
> test/java/tests/api/java/net/SocketTest.java doesn't follow JUnit exception handling convention.
> I'll upload a patch soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira