[GitHub] [spark] sunchao commented on a change in pull request #30284: [SPARK-33376][SQL] Remove the option of "sharesHadoopClasses" in Hive IsolatedClientLoader

[GitBox <gi...@apache.org>]

sunchao commented on a change in pull request #30284:
URL: https://github.com/apache/spark/pull/30284#discussion_r520008320



##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
##########
@@ -75,7 +72,6 @@ private[hive] object IsolatedClientLoader extends Logging {
               "again. Hadoop classes will not be shared between Spark and Hive metastore client. " +

Review comment:
       Forgot about this place - will fix. Yes agree that an exception might be more appropriate. It seems a bit arbitrary to fall back to 2.7.4 here since the original Hadoop version could vary based on the Hadoop profile (either 2.7.4 or 3.2.0 at the moment).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org