You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/18 02:44:00 UTC
[jira] [Commented] (BEAM-2630) TestPipeline.getAppName() doesn't
work properly when TestPipeline is used as @Rule
[ https://issues.apache.org/jira/browse/BEAM-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091028#comment-16091028 ]
ASF GitHub Bot commented on BEAM-2630:
--------------------------------------
GitHub user peihe opened a pull request:
https://github.com/apache/beam/pull/3582
[BEAM-2630] TestPipeline: construct job/app names based on Description in junit TestRule.
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[BEAM-1234] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-1234` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/peihe/incubator-beam fix-test-job-name
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3582.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3582
----
commit 63dd4a36abf8716affb2e743edcf9a60909ac9b9
Author: Pei He <pe...@apache.org>
Date: 2017-07-17T15:34:27Z
[BEAM-2630] TestPipeline: construct job/app names based on Description in junit TestRule.
----
> TestPipeline.getAppName() doesn't work properly when TestPipeline is used as @Rule
> ----------------------------------------------------------------------------------
>
> Key: BEAM-2630
> URL: https://issues.apache.org/jira/browse/BEAM-2630
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Pei He
> Assignee: Pei He
> Priority: Minor
> Fix For: 2.2.0
>
>
> Currently, TestPipeline.getAppName() looks at the stacktraces. However, when @Rule is used, it is invoked from TestPipeline.init(). And, job names of ValidatesRunnerTests all becomes pardo-init for tests in ParDo. (Same for other ValidatesRunnerTests)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)