You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/01/08 22:08:26 UTC

[GitHub] [logging-log4cxx] rm5248 commented on pull request #99: [LOG4CXX-548] Reproducible Doxygen doc generation

rm5248 commented on pull request #99:
URL: https://github.com/apache/logging-log4cxx/pull/99#issuecomment-1008162731


   The patch as given requires CMake 3.20+, but doesn't update the minimum required version.  I'd like to not have to bump the CMake version if possible.
   
   I changed the `cmake_path` directive to `file(RELATIVE_PATH LOG4CXX_REL_BIN_TO_SRC_DIR "${LOG4CXX_SOURCE_DIR}" "${CMAKE_CURRENT_BINARY_DIR}")` on my side which seems to work fine, would you be able to validate that?  I don't see where the particular example that you showed is coming in from, that only seems to be a problem with the MapFilter page.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org