[GitHub] [streampipes] dominikriemer commented on a diff in pull request #1037: [#877] Apply UI linting to configuration module

[GitBox <gi...@apache.org>]

dominikriemer commented on code in PR #1037:
URL: https://github.com/apache/streampipes/pull/1037#discussion_r1062942367


##########
ui/src/app/configuration/consul-configs-boolean/consul-configs-boolean.component.ts:
##########
@@ -21,14 +21,12 @@ import { StreampipesPeContainerConifgs } from '../shared/streampipes-pe-containe
 import { ConfigurationService } from '../shared/configuration.service';
 
 @Component({
-    selector: 'consul-configs-boolean',
+    selector: 'sp-consul-configs-boolean',

Review Comment:
   Thanks @aamirxshaikh for the awesome work!
   @bossenti The `sp` prefix in the selector only is fine for me and we don't need to prefix all files with sp as there is no danger of conflicts when reusing the component.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org