You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Adam Holley (Code Review)" <ge...@cloudera.org> on 2018/10/09 14:15:20 UTC
[Impala-ASF-CR] IMPALA-7554: Update custom cluster tests to have new logs for sentry
Adam Holley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11624
Change subject: IMPALA-7554: Update custom cluster tests to have new logs for sentry
......................................................................
IMPALA-7554: Update custom cluster tests to have new logs for sentry
This patch adds the ability to create a new log for each spawn of the
sentry service. This will enable better trouble shooting for the
custom cluster tests that restart the sentry service.
Testing:
- Ran all custom cluster tests.
Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516
---
M testdata/bin/run-sentry-service.sh
M tests/authorization/test_owner_privileges.py
M tests/common/custom_cluster_test_suite.py
3 files changed, 38 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/11624/1
--
To view, visit http://gerrit.cloudera.org:8080/11624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516
Gerrit-Change-Number: 11624
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
[Impala-ASF-CR] IMPALA-7554: Update custom cluster tests to have new logs for sentry
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11624 )
Change subject: IMPALA-7554: Update custom cluster tests to have new logs for sentry
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/11624/1/testdata/bin/run-sentry-service.sh
File testdata/bin/run-sentry-service.sh:
http://gerrit.cloudera.org:8080/#/c/11624/1/testdata/bin/run-sentry-service.sh@36
PS1, Line 36: LO
> nit: 2 spaces
Done
http://gerrit.cloudera.org:8080/#/c/11624/1/testdata/bin/run-sentry-service.sh@38
PS1, Line 38: LO
> nit: 2 spaces
Done
http://gerrit.cloudera.org:8080/#/c/11624/1/tests/common/custom_cluster_test_suite.py
File tests/common/custom_cluster_test_suite.py:
http://gerrit.cloudera.org:8080/#/c/11624/1/tests/common/custom_cluster_test_suite.py@100
PS1, Line 100:
> since we have 2 log dirs, it will be better to explain what this log_dir is
Done
http://gerrit.cloudera.org:8080/#/c/11624/1/tests/common/custom_cluster_test_suite.py@136
PS1, Line 136: self._start_sentry_service(method.func_dict[SENTRY_CONFIG],
: method.func_dict.get(SENTRY_LOG_DIR))
: # Start a clean new cluster before each test
: if IMPALA_LOG_DIR in method.func_dict:
: self._start_impala_cluster(cluster_args,
> Can be simplified to self._start_sentry_service(method.func_dir[SENTRY_CONF
Done
--
To view, visit http://gerrit.cloudera.org:8080/11624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516
Gerrit-Change-Number: 11624
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Oct 2018 16:20:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7554: Update custom cluster tests to have new logs for sentry
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11624 )
Change subject: IMPALA-7554: Update custom cluster tests to have new logs for sentry
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3303/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516
Gerrit-Change-Number: 11624
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 21:09:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7554: Update custom cluster tests to have new logs for sentry
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11624 )
Change subject: IMPALA-7554: Update custom cluster tests to have new logs for sentry
......................................................................
Patch Set 2: Code-Review+1
(6 comments)
Some formatting issues, lgtm otherwise.
http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py
File tests/authorization/test_owner_privileges.py:
http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py@139
PS2, Line 139: .format(SENTRY_BASE_LOG_DIR))
nit: I would add extra indentation for the format()
http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py@160
PS2, Line 160: .format(SENTRY_BASE_LOG_DIR))
same as line 39
http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py@254
PS2, Line 254: .format(SENTRY_BASE_LOG_DIR))
same as line 39
http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py@275
PS2, Line 275: .format(SENTRY_BASE_LOG_DIR))
same as line 39
http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py@331
PS2, Line 331: .format(SENTRY_BASE_LOG_DIR))
same as line 39
http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py@352
PS2, Line 352: .format(SENTRY_BASE_LOG_DIR))
same as line 39
--
To view, visit http://gerrit.cloudera.org:8080/11624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516
Gerrit-Change-Number: 11624
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 18:26:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7554: Update custom cluster tests to have new logs for sentry
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11624 )
Change subject: IMPALA-7554: Update custom cluster tests to have new logs for sentry
......................................................................
Patch Set 2: Code-Review+1
Csaba, can you also take another look at this?
--
To view, visit http://gerrit.cloudera.org:8080/11624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516
Gerrit-Change-Number: 11624
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Oct 2018 16:35:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7554: Update custom cluster tests to have new logs for sentry
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11624 )
Change subject: IMPALA-7554: Update custom cluster tests to have new logs for sentry
......................................................................
IMPALA-7554: Update custom cluster tests to have new logs for sentry
This patch adds the ability to create a new log for each spawn of the
sentry service. This will enable better trouble shooting for the
custom cluster tests that restart the sentry service.
Testing:
- Ran all custom cluster tests.
Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516
---
M testdata/bin/run-sentry-service.sh
M tests/authorization/test_authorization.py
M tests/authorization/test_owner_privileges.py
M tests/common/custom_cluster_test_suite.py
M tests/custom_cluster/test_redaction.py
5 files changed, 48 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/11624/2
--
To view, visit http://gerrit.cloudera.org:8080/11624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516
Gerrit-Change-Number: 11624
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-7554: Update custom cluster tests to have new logs for sentry
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11624 )
Change subject: IMPALA-7554: Update custom cluster tests to have new logs for sentry
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516
Gerrit-Change-Number: 11624
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 21:08:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7554: Update custom cluster tests to have new logs for sentry
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11624 )
Change subject: IMPALA-7554: Update custom cluster tests to have new logs for sentry
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/989/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516
Gerrit-Change-Number: 11624
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Oct 2018 14:48:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7554: Update custom cluster tests to have new logs for sentry
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11624 )
Change subject: IMPALA-7554: Update custom cluster tests to have new logs for sentry
......................................................................
IMPALA-7554: Update custom cluster tests to have new logs for sentry
This patch adds the ability to create a new log for each spawn of the
sentry service. This will enable better trouble shooting for the
custom cluster tests that restart the sentry service.
Testing:
- Ran all custom cluster tests.
Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516
Reviewed-on: http://gerrit.cloudera.org:8080/11624
Reviewed-by: Fredy Wijaya <fw...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/bin/run-sentry-service.sh
M tests/authorization/test_authorization.py
M tests/authorization/test_owner_privileges.py
M tests/common/custom_cluster_test_suite.py
M tests/custom_cluster/test_redaction.py
5 files changed, 87 insertions(+), 57 deletions(-)
Approvals:
Fredy Wijaya: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516
Gerrit-Change-Number: 11624
Gerrit-PatchSet: 4
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-7554: Update custom cluster tests to have new logs for sentry
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11624 )
Change subject: IMPALA-7554: Update custom cluster tests to have new logs for sentry
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516
Gerrit-Change-Number: 11624
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Oct 2018 01:00:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7554: Update custom cluster tests to have new logs for sentry
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11624 )
Change subject: IMPALA-7554: Update custom cluster tests to have new logs for sentry
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1027/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516
Gerrit-Change-Number: 11624
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 21:17:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7554: Update custom cluster tests to have new logs for sentry
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11624 )
Change subject: IMPALA-7554: Update custom cluster tests to have new logs for sentry
......................................................................
IMPALA-7554: Update custom cluster tests to have new logs for sentry
This patch adds the ability to create a new log for each spawn of the
sentry service. This will enable better trouble shooting for the
custom cluster tests that restart the sentry service.
Testing:
- Ran all custom cluster tests.
Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516
---
M testdata/bin/run-sentry-service.sh
M tests/authorization/test_authorization.py
M tests/authorization/test_owner_privileges.py
M tests/common/custom_cluster_test_suite.py
M tests/custom_cluster/test_redaction.py
5 files changed, 87 insertions(+), 57 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/11624/3
--
To view, visit http://gerrit.cloudera.org:8080/11624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516
Gerrit-Change-Number: 11624
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-7554: Update custom cluster tests to have new logs for sentry
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11624 )
Change subject: IMPALA-7554: Update custom cluster tests to have new logs for sentry
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/11624/1/testdata/bin/run-sentry-service.sh
File testdata/bin/run-sentry-service.sh:
http://gerrit.cloudera.org:8080/#/c/11624/1/testdata/bin/run-sentry-service.sh@36
PS1, Line 36:
nit: 2 spaces
http://gerrit.cloudera.org:8080/#/c/11624/1/testdata/bin/run-sentry-service.sh@38
PS1, Line 38:
nit: 2 spaces
http://gerrit.cloudera.org:8080/#/c/11624/1/tests/common/custom_cluster_test_suite.py
File tests/common/custom_cluster_test_suite.py:
http://gerrit.cloudera.org:8080/#/c/11624/1/tests/common/custom_cluster_test_suite.py@100
PS1, Line 100: log_dir=None
since we have 2 log dirs, it will be better to explain what this log_dir is.
http://gerrit.cloudera.org:8080/#/c/11624/1/tests/common/custom_cluster_test_suite.py@136
PS1, Line 136: if SENTRY_LOG_DIR in method.func_dict:
: self._start_sentry_service(method.func_dict[SENTRY_CONFIG],
: method.func_dict[SENTRY_LOG_DIR])
: else:
: self._start_sentry_service(method.func_dict[SENTRY_CONFIG])
Can be simplified to self._start_sentry_service(method.func_dir[SENTRY_CONFIG], method.func_dict.get(SENTRY_LOG_DIR))
--
To view, visit http://gerrit.cloudera.org:8080/11624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516
Gerrit-Change-Number: 11624
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Oct 2018 05:05:06 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7554: Update custom cluster tests to have new logs for sentry
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11624 )
Change subject: IMPALA-7554: Update custom cluster tests to have new logs for sentry
......................................................................
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py
File tests/authorization/test_owner_privileges.py:
http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py@139
PS2, Line 139: .format(SENTRY_BASE_LOG_DIR))
> nit: I would add extra indentation for the format()
If indented, fails flake8 with: E131 continuation line unaligned for hanging indent
http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py@160
PS2, Line 160: .format(SENTRY_BASE_LOG_DIR))
> same as line 39
same as above.
http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py@254
PS2, Line 254: .format(SENTRY_BASE_LOG_DIR))
> same as line 39
same as above.
http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py@275
PS2, Line 275: .format(SENTRY_BASE_LOG_DIR))
> same as line 39
same as above.
http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py@331
PS2, Line 331: .format(SENTRY_BASE_LOG_DIR))
> same as line 39
same as above.
http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py@352
PS2, Line 352: .format(SENTRY_BASE_LOG_DIR))
> same as line 39
same as above.
--
To view, visit http://gerrit.cloudera.org:8080/11624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516
Gerrit-Change-Number: 11624
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 19:15:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7554: Update custom cluster tests to have new logs for sentry
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11624 )
Change subject: IMPALA-7554: Update custom cluster tests to have new logs for sentry
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1011/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516
Gerrit-Change-Number: 11624
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Oct 2018 16:55:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7554: Update custom cluster tests to have new logs for sentry
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11624 )
Change subject: IMPALA-7554: Update custom cluster tests to have new logs for sentry
......................................................................
Patch Set 3:
Fixed formatting
--
To view, visit http://gerrit.cloudera.org:8080/11624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516
Gerrit-Change-Number: 11624
Gerrit-PatchSet: 3
Gerrit-Owner: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 20:40:53 +0000
Gerrit-HasComments: No