You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by "DevinLeamy (via GitHub)" <gi...@apache.org> on 2024/01/26 14:32:19 UTC
[PR] Added ENABLE_JEMALLOC_ALLOCATOR macro. [mesos]
DevinLeamy opened a new pull request, #492:
URL: https://github.com/apache/mesos/pull/492
Summary:
The macro is used in the agent code to determine if jemalloc was enabled in the build and provide a custom allocator configuration in the form of a global malloc_conf variable.
This commit follows from https://github.com/apache/mesos/commit/2836057c8881a62139b5db1f175d3d027bf2e645. View the commit for more details.
Test Plan:
Modified the agent code to print whether the macro is defined or not and tested on an integration test host.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added ENABLE_JEMALLOC_ALLOCATOR macro. [mesos]
Posted by "DevinLeamy (via GitHub)" <gi...@apache.org>.
DevinLeamy commented on PR #492:
URL: https://github.com/apache/mesos/pull/492#issuecomment-1912387397
> Can you update this to handle the cmake build as well?
Updated :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added ENABLE_JEMALLOC_ALLOCATOR macro. [mesos]
Posted by "bmahler (via GitHub)" <gi...@apache.org>.
bmahler commented on PR #492:
URL: https://github.com/apache/mesos/pull/492#issuecomment-1912341489
Can you update this to handle the cmake build as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added ENABLE_JEMALLOC_ALLOCATOR macro. [mesos]
Posted by "DevinLeamy (via GitHub)" <gi...@apache.org>.
DevinLeamy commented on code in PR #492:
URL: https://github.com/apache/mesos/pull/492#discussion_r1467900602
##########
cmake/CompilationConfigure.cmake:
##########
@@ -509,6 +509,10 @@ if (LINUX)
"Whether to enable the port mapping isolator."
FALSE)
+ if (ENABLE_JEMALLOC_ALLOCATOR)
+ add_definitions(-DENABLE_JEMALLOC_ALLOCATOR)
Review Comment:
As per: https://cmake.org/cmake/help/v3.8/command/add_definitions.html?highlight=i
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added ENABLE_JEMALLOC_ALLOCATOR macro. [mesos]
Posted by "bmahler (via GitHub)" <gi...@apache.org>.
bmahler commented on code in PR #492:
URL: https://github.com/apache/mesos/pull/492#discussion_r1467921888
##########
cmake/CompilationConfigure.cmake:
##########
@@ -509,6 +509,10 @@ if (LINUX)
"Whether to enable the port mapping isolator."
FALSE)
+ if (ENABLE_JEMALLOC_ALLOCATOR)
+ add_definitions(-DENABLE_JEMALLOC_ALLOCATOR)
Review Comment:
Thanks! Any reason you don't have it further up next to the option definition? Similar to how xfs's option and if condition are next to each other?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added ENABLE_JEMALLOC_ALLOCATOR macro. [mesos]
Posted by "bmahler (via GitHub)" <gi...@apache.org>.
bmahler merged PR #492:
URL: https://github.com/apache/mesos/pull/492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org