You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by Florian Holeczek <fl...@holeczek.de> on 2012/10/21 01:21:55 UTC
ATTN mentors: Ready for release?, Was: Re: Source headers and RAT
report, was: Fwd: [VOTE] JSPWiki version 2.9.0-incubating
Hi Craig and Sam,
> @mentors: before making the RC4 tag, can you take at look to current trunk
> to ensure we've dotted all the i's? So we can finally release :-D
the RAT report is looking good. This evening, I've had a look at the current trunk and committed a few more fixes. To my knowledge, all issues which led to Christian's -1 vote are fixed now.
Could you have a closer look at it please?
Thanks and regards
Florian
Re: ATTN mentors: Ready for release?, Was: Re: Source headers and
RAT report, was: Fwd: [VOTE] JSPWiki version 2.9.0-incubating
Posted by Florian Holeczek <fl...@holeczek.de>.
Hi Craig,
> Where is the RAT report for the new proposed release? I can take a look.
I've just uploaded the RAT report as well as the related distribution artifacts to [1].
This stuff is based on the trunk with svn revision #1401006.
Regards
Florian
[1] http://people.apache.org/~florianh/JSPWiki-2.9.0-incubating-13/
Re: ATTN mentors: Ready for release?, Was: Re: Source headers and RAT
report, was: Fwd: [VOTE] JSPWiki version 2.9.0-incubating
Posted by Harry Metske <ha...@gmail.com>.
looks good to me.
thanks for all your efforts Florian,
Harry
2012/10/26 Florian Holeczek <fl...@holeczek.de>
> Hi all,
>
> I've just committed a few more updates after having received Christian
> Grobmeier's review of the artifacts at [1]:
>
> > 1) NOTICE file contains 2008 as copyright date, should be 2008 - 2012
> > 2) Is it necessary to contain the JSPWIki Resolution in the src
> > package? It might confuse users (src & bin)
> > 3) in the bin package is a graffle file included. I consider this a
> > source - is it really intendet?
> > 4) i am not a nitpicker, but in in atom.css line 20 is a whitespace
> missing
> >
> > I think 1 & 2 should be done because it might be easy to fix.
> > 3 & 4 is just what I found while checking everything, but not worth to
> > "fix" for this release
>
> Thanks to Christian!
>
> I've fixed #1, #2 and #4. I haven't changed #3, because I think the doc
> directory is something we should restructure in the future anyway. At the
> moment, a fix would only be a more or less confusing extra step in
> build.xml.
>
> Thinking positively, I've furthermore created the tag
> jspwiki_2_9_0_incubating_rc4. The distribution artifacts based on this one,
> and also the corresponding RAT report, can be found at [2].
>
> If Craig (or anyone else) doesn't find any further issues, we could vote
> on this stuff in the next days.
>
> Regards
> Florian
>
> [1] http://people.apache.org/~florianh/JSPWiki-2.9.0-incubating-13/
> [2] http://people.apache.org/~florianh/JSPWiki-2.9.0-incubating-rc4/
>
Re: ATTN mentors: Ready for release?, Was: Re: Source headers and
RAT report, was: Fwd: [VOTE] JSPWiki version 2.9.0-incubating
Posted by Florian Holeczek <fl...@holeczek.de>.
Hi all,
I've just committed a few more updates after having received Christian Grobmeier's review of the artifacts at [1]:
> 1) NOTICE file contains 2008 as copyright date, should be 2008 - 2012
> 2) Is it necessary to contain the JSPWIki Resolution in the src
> package? It might confuse users (src & bin)
> 3) in the bin package is a graffle file included. I consider this a
> source - is it really intendet?
> 4) i am not a nitpicker, but in in atom.css line 20 is a whitespace missing
>
> I think 1 & 2 should be done because it might be easy to fix.
> 3 & 4 is just what I found while checking everything, but not worth to
> "fix" for this release
Thanks to Christian!
I've fixed #1, #2 and #4. I haven't changed #3, because I think the doc directory is something we should restructure in the future anyway. At the moment, a fix would only be a more or less confusing extra step in build.xml.
Thinking positively, I've furthermore created the tag jspwiki_2_9_0_incubating_rc4. The distribution artifacts based on this one, and also the corresponding RAT report, can be found at [2].
If Craig (or anyone else) doesn't find any further issues, we could vote on this stuff in the next days.
Regards
Florian
[1] http://people.apache.org/~florianh/JSPWiki-2.9.0-incubating-13/
[2] http://people.apache.org/~florianh/JSPWiki-2.9.0-incubating-rc4/
Re: ATTN mentors: Ready for release?, Was: Re: Source headers and RAT report, was: Fwd: [VOTE] JSPWiki version 2.9.0-incubating
Posted by Craig L Russell <cr...@oracle.com>.
Hi Florian,
Where is the RAT report for the new proposed release? I can take a look.
Craig
On Oct 20, 2012, at 4:21 PM, Florian Holeczek wrote:
> Hi Craig and Sam,
>
>> @mentors: before making the RC4 tag, can you take at look to
>> current trunk
>> to ensure we've dotted all the i's? So we can finally release :-D
>
> the RAT report is looking good. This evening, I've had a look at the
> current trunk and committed a few more fixes. To my knowledge, all
> issues which led to Christian's -1 vote are fixed now.
> Could you have a closer look at it please?
>
> Thanks and regards
> Florian
Craig L Russell
Architect, Oracle
http://db.apache.org/jdo
408 276-5638 mailto:Craig.Russell@oracle.com
P.S. A good JDO? O, Gasp!