[GitHub] [avro] kojiromike commented on a diff in pull request #2319: AVRO-0: Python patched up ipc issues

["kojiromike (via GitHub)" <gi...@apache.org>]

kojiromike commented on code in PR #2319:
URL: https://github.com/apache/avro/pull/2319#discussion_r1264272047


##########
lang/py/avro/schema.py:
##########
@@ -873,20 +873,37 @@ def __init__(
         if schema_type == "request":
             Schema.__init__(self, schema_type, other_props)
         else:
-            NamedSchema.__init__(self, schema_type, name, namespace, names, other_props, validate_names=validate_names)
+            NamedSchema.__init__(
+                self,
+                schema_type,
+                name,
+                namespace,
+                names,
+                other_props,
+                validate_names=validate_names,
+            )
 
         names = names or Names(validate_names=self.validate_names)
-        if schema_type == "record":
+        if (schema_type == "record") or (schema_type == "error"):

Review Comment:
   ```suggestion
           if schema_type in ("record", "error"):
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org