You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "lvyanquan (via GitHub)" <gi...@apache.org> on 2023/08/08 04:45:14 UTC

[GitHub] [spark] lvyanquan commented on a diff in pull request #42380: [SPARK-44696][SQL] Support different timestamp precise for `from_json` function

lvyanquan commented on code in PR #42380:
URL: https://github.com/apache/spark/pull/42380#discussion_r1286588941


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala:
##########
@@ -286,7 +286,14 @@ class JacksonParser(
           }
 
         case VALUE_NUMBER_INT =>
-          parser.getLongValue * 1000000L

Review Comment:
   We still need to judge the precise in order to throw exception properly, thus I think it‘s be better to support these two precisions.



##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala:
##########
@@ -286,7 +286,14 @@ class JacksonParser(
           }
 
         case VALUE_NUMBER_INT =>
-          parser.getLongValue * 1000000L

Review Comment:
   We still need to judge the precise in order to throw exception properly, thus I think it‘s be better to support these two precisions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org