You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Giridharan Kesavan (JIRA)" <ji...@apache.org> on 2009/04/08 15:07:13 UTC
[jira] Created: (ZOOKEEPER-371) to implement jdiff
to implement jdiff
-------------------
Key: ZOOKEEPER-371
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
Project: Zookeeper
Issue Type: Improvement
Components: build
Affects Versions: 3.2.0
Environment: to implement jdiff
Reporter: Giridharan Kesavan
Assignee: Giridharan Kesavan
Fix For: 3.2.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-371) to implement jdiff
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-371:
------------------------------------
Status: Patch Available (was: Open)
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-371) to implement jdiff
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated ZOOKEEPER-371:
-----------------------------------------
Status: Open (was: Patch Available)
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-371) to implement jdiff
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated ZOOKEEPER-371:
-----------------------------------------
Attachment: zookeeper-371.patch
this patch enables jdiff for zookeeper.
Tnx!
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-371) to implement jdiff
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated ZOOKEEPER-371:
-----------------------------------------
Status: Patch Available (was: Open)
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch, zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699037#action_12699037 ]
Mahadev konar commented on ZOOKEEPER-371:
-----------------------------------------
giri,
I think what ben meant was --
run jdiff on svn trunk and then run jdiff on svn trunk+patch. If their is a change then we -1 the patch. That way we do not need to check in the 3.1.1 api docs. can we do that or doing what you suggest is the right way to go?
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-371) to implement jdiff
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated ZOOKEEPER-371:
-----------------------------------------
Status: Open (was: Patch Available)
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700652#action_12700652 ]
Giridharan Kesavan commented on ZOOKEEPER-371:
----------------------------------------------
-1 for the release audit is expected as the jdiff is creating files on the fly; but for the author tags I think I should talk to Nigel
tnx!
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699995#action_12699995 ]
Hadoop QA commented on ZOOKEEPER-371:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12405402/zookeeper-371.patch
against trunk revision 765797.
-1 @author. The patch appears to contain 48 @author tags which the ZooKeeper community has agreed to not allow in code contributions.
+1 tests included. The patch appears to include 1 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
-1 release audit. The applied patch generated 109 release audit warnings (more than the trunk's current 105 warnings).
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/37/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/37/artifact/trunk/current/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/37/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/37/console
This message is automatically generated.
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701451#action_12701451 ]
Hadoop QA commented on ZOOKEEPER-371:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12406100/zookeeper-371.patch
against trunk revision 766897.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
-1 release audit. The applied patch generated 142 release audit warnings (more than the trunk's current 105 warnings).
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/46/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/46/artifact/trunk/current/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/46/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/46/console
This message is automatically generated.
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch, zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698818#action_12698818 ]
Benjamin Reed commented on ZOOKEEPER-371:
-----------------------------------------
shouldn't this be generated rather than checked in?
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699040#action_12699040 ]
Giridharan Kesavan commented on ZOOKEEPER-371:
----------------------------------------------
{quote}
run jdiff on svn trunk and then run jdiff on svn trunk+patch. If their is a change then we -1 the patch. That way we do not need to check in the 3.1.1 api docs. can we do that or doing what you suggest is the right way to go?
{quote}
This patch that I submitted is to run during the nightly to show up any any changes b/w 3.1.1 and 3.2.0.
But I understand the requirement that we want this jdiff as part of the path test process, that way we can say whether a path has introduced any api changes and do a +1/-1 based on that. I already have this in my task list and I would be working on this enhancement soon.
tnx
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-371) to implement jdiff
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699040#action_12699040 ]
Giridharan Kesavan edited comment on ZOOKEEPER-371 at 4/14/09 8:44 PM:
-----------------------------------------------------------------------
{quote}
run jdiff on svn trunk and then run jdiff on svn trunk+patch. If their is a change then we -1 the patch. That way we do not need to check in the 3.1.1 api docs. can we do that or doing what you suggest is the right way to go?
{quote}
This patch that I submitted is to run during the nightly to show up any changes b/w 3.1.1 and 3.2.0.
But I understand the requirement that we want this jdiff as part of the patch test process, that way we can say whether a patch has introduced any api changes and do a +1/-1 based on that. I already have this in my task list and I would be working on this enhancement soon.
tnx
was (Author: gkesavan):
{quote}
run jdiff on svn trunk and then run jdiff on svn trunk+patch. If their is a change then we -1 the patch. That way we do not need to check in the 3.1.1 api docs. can we do that or doing what you suggest is the right way to go?
{quote}
This patch that I submitted is to run during the nightly to show up any any changes b/w 3.1.1 and 3.2.0.
But I understand the requirement that we want this jdiff as part of the path test process, that way we can say whether a path has introduced any api changes and do a +1/-1 based on that. I already have this in my task list and I would be working on this enhancement soon.
tnx
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-371) to implement jdiff
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated ZOOKEEPER-371:
-----------------------------------------
Status: Patch Available (was: Open)
Mahadev,
Could you please review this?
tnx!
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700239#action_12700239 ]
Mahadev konar commented on ZOOKEEPER-371:
-----------------------------------------
giri can you take a look at this? is this expected?
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-371) to implement jdiff
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated ZOOKEEPER-371:
-----------------------------------------
Attachment: zookeeper-371.patch
this patch excludes jute package for jdiff
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch, zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-371) to implement jdiff
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated ZOOKEEPER-371:
-----------------------------------------
Status: Patch Available (was: Open)
patch build stuck on hudson for more that 10Hrs. I killed the patch build.
Resubmitting the patch to hudson.
tnx
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-371) to implement jdiff
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-371:
-----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed revision 767596
Thanks Giri!
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch, zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699852#action_12699852 ]
Mahadev konar commented on ZOOKEEPER-371:
-----------------------------------------
+1 on the patch . I ll wait for hudson to run through it.
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-371) to implement jdiff
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated ZOOKEEPER-371:
-----------------------------------------
Status: Open (was: Patch Available)
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-371) to implement jdiff
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-371:
------------------------------------
Status: Open (was: Patch Available)
retrying hudson...
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-371) to implement jdiff
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated ZOOKEEPER-371:
-----------------------------------------
Status: Patch Available (was: Open)
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699034#action_12699034 ]
Giridharan Kesavan commented on ZOOKEEPER-371:
----------------------------------------------
Please correct me if I'm wrong.
patch contains api for 3.1.1(zookeeper_3.1.1.xml) and tha api-xml target would generate the api doc for 3.2.0(trunk version)
This 3.1.1 api doc is required to compare the api changes b/w 3.1.1 and 3.2.0.
Thanks,
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-371) to implement jdiff
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated ZOOKEEPER-371:
-----------------------------------------
Attachment: zookeeper-371.patch
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-371) to implement jdiff
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated ZOOKEEPER-371:
-----------------------------------------
Attachment: (was: zookeeper-371.patch)
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701970#action_12701970 ]
Hudson commented on ZOOKEEPER-371:
----------------------------------
Integrated in ZooKeeper-trunk #288 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/288/])
. jdiff documentation included in build/release
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch, zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701379#action_12701379 ]
Giridharan Kesavan commented on ZOOKEEPER-371:
----------------------------------------------
I'm working on recreating this patch to exclude the jute package.
-tnx
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701610#action_12701610 ]
Patrick Hunt commented on ZOOKEEPER-371:
----------------------------------------
+1, looks great. I generated the release package and it looks good.
Thanks Giri!
> to implement jdiff
> -------------------
>
> Key: ZOOKEEPER-371
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.0
> Environment: to implement jdiff
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 3.2.0
>
> Attachments: zookeeper-371.patch, zookeeper-371.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.