You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/07/31 11:14:00 UTC
[jira] [Commented] (IMPALA-8810) ExplainTest.testScanNodeFsScheme
fails if Orc support is disabled
[ https://issues.apache.org/jira/browse/IMPALA-8810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897055#comment-16897055 ]
ASF subversion and git services commented on IMPALA-8810:
---------------------------------------------------------
Commit ffb78e24d91fadd3ffb79692211a6208a9eaedf1 in impala's branch refs/heads/master from Csaba Ringhofer
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=ffb78e2 ]
IMPALA-8810: Fix ExplainTest when Orc support is disabled
The problem was that ExplainTest only mocks
HdfsPartition.getFileFormat() but not
HdfsPartition.getInputFormatDescriptor(), and the latter is called
then dereferenced during testScanNodeFsScheme() (only if Orc support
is disabled), leading to null pointer exception.
I went for the lazy solution of replacing
getInputFormatDescriptor().getFileFormat() calls with getFileFormat().
The other solution would have been to mock getInputFormatDescriptor()
too, but I think that would have only added unnecessary dependencies to
the test.
Change-Id: I0d8bcb67e095a63beb9059568ba34b7fd261f233
Reviewed-on: http://gerrit.cloudera.org:8080/13956
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> ExplainTest.testScanNodeFsScheme fails if Orc support is disabled
> -----------------------------------------------------------------
>
> Key: IMPALA-8810
> URL: https://issues.apache.org/jira/browse/IMPALA-8810
> Project: IMPALA
> Issue Type: Bug
> Components: Frontend
> Affects Versions: Impala 3.3.0
> Reporter: Csaba Ringhofer
> Priority: Major
>
> The problem is caused by going into this block when Orc support is disabled: https://github.com/apache/impala/blob/51f30a6b9088cf3a0217a49a5792f1b41a8ad51b/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java#L416
> + that ExplainTest only mocks HdfsPartition.getFileFormat() but not HdfsPartition.part.getInputFormatDescriptor().
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org