Re: [PR] bugfix(airflowctl): support primitive and datamodel in operation parameters and fix trigger DagRun [airflow]

["jscheffl (via GitHub)" <gi...@apache.org>]

jscheffl commented on code in PR #54073:
URL: https://github.com/apache/airflow/pull/54073#discussion_r2250099228


##########
airflow-ctl/src/airflowctl/api/operations.py:
##########
@@ -554,11 +554,10 @@ def trigger(
         self, dag_id: str, trigger_dag_run: TriggerDAGRunPostBody
     ) -> DAGRunResponse | ServerResponseError:
         """Create a dag run."""
+        if trigger_dag_run.conf is None:
+            trigger_dag_run.conf = {}

Review Comment:
   Instead of this is it not easier to define `{}` as default in the `TriggerDAGRunPostBody`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org