You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/02/23 00:05:49 UTC
[GitHub] gjacoby126 commented on a change in pull request #441: PHOENIX-5089
Add tenantId parameter to IndexScrunityTool
gjacoby126 commented on a change in pull request #441: PHOENIX-5089 Add tenantId parameter to IndexScrunityTool
URL: https://github.com/apache/phoenix/pull/441#discussion_r259549064
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/IndexColumnNames.java
##########
@@ -61,6 +68,9 @@ public IndexColumnNames(final PTable pdataTable, final PTable pindexTable) {
if (pindexTable.getViewIndexId() != null) {
offset++;
}
+ if (forTenant && pindexTable.isMultiTenant()) {
Review comment:
@gokceni - Would the forTenant make a difference here? What if it were a multi-tenant global view index? The _IDX table would still be <ViewIndexId, TenantId, Other indexed columns>, but presumably forTenant would be false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services